You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/29 22:57:47 UTC

[GitHub] [airflow] vchiapaikeo opened a new pull request, #28643: Nest header blocks in divs to fix dagid copy nit on dag.html

vchiapaikeo opened a new pull request, #28643:
URL: https://github.com/apache/airflow/pull/28643

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   closes: https://github.com/apache/airflow/issues/22320
   
   Fixes a UI nit where copying the dag_id on dag.html causes the schedule to get copied with it. I am separating the inline header blocks with divs.
   
   Before:
   
   https://user-images.githubusercontent.com/9200263/210018907-e2b12faa-be7c-486d-97b7-74b93b38fd45.mov
   
   After:
   
   https://user-images.githubusercontent.com/9200263/210018922-528d14ca-9802-4e42-801c-b1fd927c3972.mov
   
   
   
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] pierrejeambrun merged pull request #28643: Nest header blocks in divs to fix dagid copy nit on dag.html

Posted by GitBox <gi...@apache.org>.
pierrejeambrun merged PR #28643:
URL: https://github.com/apache/airflow/pull/28643


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #28643: Nest header blocks in divs to fix dagid copy nit on dag.html

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28643:
URL: https://github.com/apache/airflow/pull/28643#issuecomment-1370739115

   Looks good. Tested it locally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org