On fixing the authz problem (was Re: herding 1.1 issues into the corral)

[Greg Hudson <gh...@MIT.EDU>]

On Wed, 2004-07-07 at 03:41, Michael W Thelen wrote:
> I'm
> thinking that a new svn_config function is needed to provide the full
> list of config sections (or call a callback for each one).

Correct; to implement Ben's solution, we need an svn_config_enumerate
analog for sections rather than variables within a section.  For
consistency, a callback interface makes sense, although in a vacuum I'd
suggest returning an array as you first suggest, since C callbacks are
awkward.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: On fixing the authz problem (was Re: herding 1.1 issues into the corral)

["Glenn A. Thompson" <gt...@cdr.net>]

Hey,

Michael W Thelen wrote:

>* Greg Hudson <gh...@MIT.EDU> [2004-07-07 06:46]:
>  
>
>>On Wed, 2004-07-07 at 03:41, Michael W Thelen wrote:
>>    
>>
>>>I'm
>>>thinking that a new svn_config function is needed to provide the full
>>>list of config sections (or call a callback for each one).
>>>      
>>>
>>Correct; to implement Ben's solution, we need an svn_config_enumerate
>>analog for sections rather than variables within a section.  For
>>consistency, a callback interface makes sense, although in a vacuum I'd
>>suggest returning an array as you first suggest, since C callbacks are
>>awkward.
>>    
>>
>
>Thanks, that should be the last piece in the puzzle for implementing
>Ben's solution.  I'll do that tonight (the callback for consistency) and
>if all goes well, I should have a patch for review by tomorrow.
>
Cool! 
I haven't been keeping up with Subversion at all.  But, it's weird, for 
some unknown reason I clicked on this thread.
on page 13 of http://www.cdrguys.com/subversion/pluggable3.pdf  (FS 
Configuration usage) I mention this change along with one other small 
change.  The other thing I wanted was a "new" method to create an empty 
svn_config_t programmatically.  It may be there now I wouldn't know.  I 
had patches for them a long long long time ago.  Anyway, the new method 
would be really nice to have if it's not already there.

Thanks,
gat

Re: On fixing the authz problem (was Re: herding 1.1 issues into the corral)

[Michael W Thelen <th...@cs.utah.edu>]

* Greg Hudson <gh...@MIT.EDU> [2004-07-07 06:46]:
> On Wed, 2004-07-07 at 03:41, Michael W Thelen wrote:
> > I'm
> > thinking that a new svn_config function is needed to provide the full
> > list of config sections (or call a callback for each one).
> 
> Correct; to implement Ben's solution, we need an svn_config_enumerate
> analog for sections rather than variables within a section.  For
> consistency, a callback interface makes sense, although in a vacuum I'd
> suggest returning an array as you first suggest, since C callbacks are
> awkward.

Thanks, that should be the last piece in the puzzle for implementing
Ben's solution.  I'll do that tonight (the callback for consistency) and
if all goes well, I should have a patch for review by tomorrow.

-- Mike

-- 
Michael W. Thelen
We who cut mere stones must always be envisioning cathedrals.
                -- Quarry worker's creed