You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "azexcy (via GitHub)" <gi...@apache.org> on 2023/03/15 12:35:38 UTC
[GitHub] [shardingsphere] azexcy opened a new pull request, #24627: Add junit-jupiter-engine dependency
azexcy opened a new pull request, #24627:
URL: https://github.com/apache/shardingsphere/pull/24627
Changes proposed in this pull request:
- Add junit-jupiter-engine dependency
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy closed pull request #24627: Add junit-jupiter-engine dependency
Posted by "azexcy (via GitHub)" <gi...@apache.org>.
azexcy closed pull request #24627: Add junit-jupiter-engine dependency
URL: https://github.com/apache/shardingsphere/pull/24627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24627: Add junit-jupiter-engine dependency
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24627:
URL: https://github.com/apache/shardingsphere/pull/24627#issuecomment-1469993923
## [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24627?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24627](https://codecov.io/gh/apache/shardingsphere/pull/24627?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa03920) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7a75f9e4278aa23f56fba65754effee741e473e9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a75f9e) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head fa03920 differs from pull request most recent head 4416515. Consider uploading reports for the commit 4416515 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24627 +/- ##
============================================
- Coverage 50.00% 50.00% -0.01%
Complexity 1597 1597
============================================
Files 3336 3336
Lines 54564 54564
Branches 10037 8075 -1962
============================================
- Hits 27283 27282 -1
+ Misses 24846 24821 -25
- Partials 2435 2461 +26
```
[see 18 files with indirect coverage changes](https://codecov.io/gh/apache/shardingsphere/pull/24627/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy commented on pull request #24627: Add junit-jupiter-engine dependency
Posted by "azexcy (via GitHub)" <gi...@apache.org>.
azexcy commented on PR #24627:
URL: https://github.com/apache/shardingsphere/pull/24627#issuecomment-1480634689
This issue has been fixed, so close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy commented on pull request #24627: Add junit-jupiter-engine dependency
Posted by "azexcy (via GitHub)" <gi...@apache.org>.
azexcy commented on PR #24627:
URL: https://github.com/apache/shardingsphere/pull/24627#issuecomment-1469948351
This is in conflict with junit-vintage-engine, waiting for the solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org