You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/18 12:05:55 UTC

[GitHub] [incubator-kyuubi] cxzl25 opened a new pull request #2169: [WIP][KYUUBI #2035] Hive Backend Engine - build/distsupport

cxzl25 opened a new pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169


   ### _Why are the changes needed?_
   `build/dist` supports hive.
   close https://github.com/apache/incubator-kyuubi/issues/2035
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2169: [WIP][KYUUBI #2035] Hive Backend Engine - `build/dist`support

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#issuecomment-1072374177


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2169](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (237935a) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/62f685ff69253e6979d5f4490858ff75fea78f19?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (62f685f) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2169      +/-   ##
   ============================================
   - Coverage     61.45%   61.43%   -0.02%     
     Complexity      117      117              
   ============================================
     Files           323      323              
     Lines         15588    15588              
     Branches       1999     1999              
   ============================================
   - Hits           9580     9577       -3     
   - Misses         5193     5195       +2     
   - Partials        815      816       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
   | [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `67.46% <0.00%> (-2.41%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [62f685f...237935a](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2169: [WIP][KYUUBI #2035] Hive Backend Engine - `build/dist` support

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#issuecomment-1072374177


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2169](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (15edf01) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/0025505ae98b6d8c9af175c5b45fb2c0db00e7a9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0025505) will **increase** coverage by `0.22%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 15edf01 differs from pull request most recent head 69558bb. Consider uploading reports for the commit 69558bb to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2169      +/-   ##
   ============================================
   + Coverage     61.21%   61.43%   +0.22%     
   - Complexity       69      117      +48     
   ============================================
     Files           329      323       -6     
     Lines         15739    15588     -151     
     Branches       2010     1999      -11     
   ============================================
   - Hits           9634     9577      -57     
   + Misses         5287     5195      -92     
   + Partials        818      816       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...i/engine/hive/operation/HiveOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1oaXZlLXNxbC1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2hpdmUvb3BlcmF0aW9uL0hpdmVPcGVyYXRpb25NYW5hZ2VyLnNjYWxh) | `30.00% <0.00%> (-18.58%)` | :arrow_down: |
   | [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `82.75% <0.00%> (-2.59%)` | :arrow_down: |
   | [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `67.46% <0.00%> (-2.41%)` | :arrow_down: |
   | [...mon/src/main/scala/org/apache/kyuubi/Logging.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9Mb2dnaW5nLnNjYWxh) | `39.72% <0.00%> (-1.37%)` | :arrow_down: |
   | [...in/scala/org/apache/kyuubi/server/api/v1/dto.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL2R0by5zY2FsYQ==) | `68.51% <0.00%> (-0.45%)` | :arrow_down: |
   | [...ine/spark/operation/SparkSQLOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vU3BhcmtTUUxPcGVyYXRpb25NYW5hZ2VyLnNjYWxh) | `83.33% <0.00%> (-0.39%)` | :arrow_down: |
   | [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `92.77% <0.00%> (-0.18%)` | :arrow_down: |
   | [...rg/apache/kyuubi/server/BackendServiceMetric.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvQmFja2VuZFNlcnZpY2VNZXRyaWMuc2NhbGE=) | `96.00% <0.00%> (-0.16%)` | :arrow_down: |
   | [...apache/kyuubi/service/AbstractBackendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL0Fic3RyYWN0QmFja2VuZFNlcnZpY2Uuc2NhbGE=) | `97.87% <0.00%> (-0.13%)` | :arrow_down: |
   | [...la/org/apache/kyuubi/session/AbstractSession.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0Fic3RyYWN0U2Vzc2lvbi5zY2FsYQ==) | `98.88% <0.00%> (-0.04%)` | :arrow_down: |
   | ... and [18 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0025505...69558bb](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2169: [KYUUBI #2035] Hive Backend Engine - `build/dist` support

Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#issuecomment-1073555108


   Thanks, merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #2169: [WIP][KYUUBI #2035] Hive Backend Engine - `build/dist` support

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#discussion_r830008025



##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
   cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
 fi
 
+if [[ "$HIVE_PROVIDED" != "true" ]]; then

Review comment:
       >I forgot, this PR needs to be merged in https://github.com/apache/incubator-kyuubi/issues/2024 to work properly.
   
   yes, you are right. 
   
   > not related to this PR only, if we build/package without hive distribution with maven, the below will fail
   
   This is another issue we may face if we `build/dist ` with download releases skipped.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] cxzl25 commented on a change in pull request #2169: [WIP][KYUUBI #2035] Hive Backend Engine - `build/dist` support

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on a change in pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#discussion_r830004802



##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
   cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
 fi
 
+if [[ "$HIVE_PROVIDED" != "true" ]]; then

Review comment:
       I forgot, this PR needs to be merged in https://github.com/apache/incubator-kyuubi/issues/2024 to work properly. 
   That's why I added WIP to the title.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] cxzl25 commented on a change in pull request #2169: [WIP][KYUUBI #2035] Hive Backend Engine - `build/dist` support

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on a change in pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#discussion_r830016662



##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
   cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
 fi
 
+if [[ "$HIVE_PROVIDED" != "true" ]]; then

Review comment:
       I probably know what you mean.
   If you mean to use maven -D parameter to skip the release download of hive or other engines, an error will be reported here.
   ```
   build/dist --tgz --spark-provided --flink-provided  -Pspark-3.2 -Dhive.archive.download.skip=true
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #2169: [WIP][KYUUBI #2035] Hive Backend Engine - `build/dist`support

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#discussion_r829996851



##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
   cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
 fi
 
+if [[ "$HIVE_PROVIDED" != "true" ]]; then

Review comment:
       not related to this PR only, if we build/package without hive distribution with maven, the below will fail




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #2169: [WIP][KYUUBI #2035] Hive Backend Engine - build/distsupport

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#issuecomment-1072348908


   ## Build
   ![image](https://user-images.githubusercontent.com/3898450/159000148-7b8fbc64-e676-49ec-8144-c721d6dce8e1.png)
   ## List
   ![image](https://user-images.githubusercontent.com/3898450/159000277-049a9688-068f-4f17-b680-7e9fb500a7a0.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2169: [WIP][KYUUBI #2035] Hive Backend Engine - `build/dist`support

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#issuecomment-1072374177


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2169](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (237935a) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/62f685ff69253e6979d5f4490858ff75fea78f19?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (62f685f) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 237935a differs from pull request most recent head 15edf01. Consider uploading reports for the commit 15edf01 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2169      +/-   ##
   ============================================
   - Coverage     61.45%   61.43%   -0.02%     
     Complexity      117      117              
   ============================================
     Files           323      323              
     Lines         15588    15588              
     Branches       1999     1999              
   ============================================
   - Hits           9580     9577       -3     
   - Misses         5193     5195       +2     
   - Partials        815      816       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
   | [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `67.46% <0.00%> (-2.41%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [62f685f...15edf01](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #2169: [WIP][KYUUBI #2035] Hive Backend Engine - build/distsupport

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#issuecomment-1072348908


   ## Build
   ![image](https://user-images.githubusercontent.com/3898450/159000148-7b8fbc64-e676-49ec-8144-c721d6dce8e1.png)
   ## List
   ![image](https://user-images.githubusercontent.com/3898450/159000277-049a9688-068f-4f17-b680-7e9fb500a7a0.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2169: [WIP][KYUUBI #2035] Hive Backend Engine - `build/dist`support

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#issuecomment-1072374177


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2169](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (237935a) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/62f685ff69253e6979d5f4490858ff75fea78f19?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (62f685f) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 237935a differs from pull request most recent head 15edf01. Consider uploading reports for the commit 15edf01 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2169      +/-   ##
   ============================================
   - Coverage     61.45%   61.43%   -0.02%     
     Complexity      117      117              
   ============================================
     Files           323      323              
     Lines         15588    15588              
     Branches       1999     1999              
   ============================================
   - Hits           9580     9577       -3     
   - Misses         5193     5195       +2     
   - Partials        815      816       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
   | [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `67.46% <0.00%> (-2.41%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [62f685f...15edf01](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #2169: [WIP][KYUUBI #2035] Hive Backend Engine - `build/dist` support

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#discussion_r830027400



##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
   cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
 fi
 
+if [[ "$HIVE_PROVIDED" != "true" ]]; then

Review comment:
       yes, and the error maybe suppressed and we don't know why




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #2169: [KYUUBI #2035] Hive Backend Engine - `build/dist` support

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#issuecomment-1073503597


   The following build commands are executed successfully on the local computer.
   
   ```bash
   build/dist --tgz --spark-provided --flink-provided --hive-provided  -Pspark-3.2
   ```
   
   ```bash
   build/dist --tgz --spark-provided --flink-provided   -Pspark-3.2 -Pmirror-cdn
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] cxzl25 commented on a change in pull request #2169: [WIP][KYUUBI #2035] Hive Backend Engine - `build/dist` support

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on a change in pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#discussion_r830004802



##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
   cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
 fi
 
+if [[ "$HIVE_PROVIDED" != "true" ]]; then

Review comment:
       I forgot, this PR needs to be merged in https://github.com/apache/incubator-kyuubi/issues/2024 to work properly. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] cxzl25 commented on a change in pull request #2169: [WIP][KYUUBI #2035] Hive Backend Engine - `build/dist` support

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on a change in pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#discussion_r830004802



##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
   cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
 fi
 
+if [[ "$HIVE_PROVIDED" != "true" ]]; then

Review comment:
       I forgot, this PR needs to be merged in https://github.com/apache/incubator-kyuubi/issues/2024 to work properly. 

##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
   cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
 fi
 
+if [[ "$HIVE_PROVIDED" != "true" ]]; then

Review comment:
       I forgot, this PR needs to be merged in https://github.com/apache/incubator-kyuubi/issues/2024 to work properly. 
   That's why I added WIP to the title.

##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
   cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
 fi
 
+if [[ "$HIVE_PROVIDED" != "true" ]]; then

Review comment:
       I probably know what you mean.
   If you mean to use maven -D parameter to skip the release download of hive or other engines, an error will be reported here.
   ```
   build/dist --tgz --spark-provided --flink-provided  -Pspark-3.2 -Dhive.archive.download.skip=true
   ```

##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
   cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
 fi
 
+if [[ "$HIVE_PROVIDED" != "true" ]]; then

Review comment:
       Maybe do this after `#Parse arguments`.
   
   ```bash
   mvn help:evaluate -Dexpression=hive.archive.download.skip -Dhive.archive.download.skip=false  | grep -v INFO | grep -v WARNING
   ```
   
   Do I need to make changes in this PR? or new open issue to do this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2169: [WIP][KYUUBI #2035] Hive Backend Engine - `build/dist`support

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#issuecomment-1072374177


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2169](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (237935a) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/62f685ff69253e6979d5f4490858ff75fea78f19?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (62f685f) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2169      +/-   ##
   ============================================
   - Coverage     61.45%   61.43%   -0.02%     
     Complexity      117      117              
   ============================================
     Files           323      323              
     Lines         15588    15588              
     Branches       1999     1999              
   ============================================
   - Hits           9580     9577       -3     
   - Misses         5193     5195       +2     
   - Partials        815      816       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
   | [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `67.46% <0.00%> (-2.41%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [62f685f...237935a](https://codecov.io/gh/apache/incubator-kyuubi/pull/2169?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 closed pull request #2169: [KYUUBI #2035] Hive Backend Engine - `build/dist` support

Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] cxzl25 commented on a change in pull request #2169: [WIP][KYUUBI #2035] Hive Backend Engine - `build/dist` support

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on a change in pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#discussion_r830044529



##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
   cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
 fi
 
+if [[ "$HIVE_PROVIDED" != "true" ]]; then

Review comment:
       Maybe do this after `#Parse arguments`.
   
   ```bash
   mvn help:evaluate -Dexpression=hive.archive.download.skip -Dhive.archive.download.skip=false  | grep -v INFO | grep -v WARNING
   ```
   
   Do I need to make changes in this PR? or new open issue to do this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #2169: [WIP][KYUUBI #2035] Hive Backend Engine - `build/dist`support

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#discussion_r829996851



##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
   cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
 fi
 
+if [[ "$HIVE_PROVIDED" != "true" ]]; then

Review comment:
       not related to this PR only, if we build/package without hive distribution with maven, the below will fail

##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
   cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
 fi
 
+if [[ "$HIVE_PROVIDED" != "true" ]]; then

Review comment:
       >I forgot, this PR needs to be merged in https://github.com/apache/incubator-kyuubi/issues/2024 to work properly.
   
   yes, you are right. 
   
   > not related to this PR only, if we build/package without hive distribution with maven, the below will fail
   
   This is another issue we may face if we `build/dist ` with download releases skipped.

##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
   cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
 fi
 
+if [[ "$HIVE_PROVIDED" != "true" ]]; then

Review comment:
       yes, and the error maybe suppressed and we don't know why

##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
   cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
 fi
 
+if [[ "$HIVE_PROVIDED" != "true" ]]; then

Review comment:
       Let‘s fix this in another ticket




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org