You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ad...@apache.org on 2017/12/18 19:34:54 UTC
[18/50] [abbrv] james-project git commit: JAMES-2199 Use
Arrays.asList() to avoid making a copy of idSet
JAMES-2199 Use Arrays.asList() to avoid making a copy of idSet
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/f7b8a64b
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/f7b8a64b
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/f7b8a64b
Branch: refs/heads/master
Commit: f7b8a64b87cf37fd12f53343064426e32081c8ec
Parents: 02f8dda
Author: Daniel Trebbien <dt...@gmail.com>
Authored: Fri Oct 20 10:22:24 2017 -0500
Committer: Antoine Duprat <ad...@linagora.com>
Committed: Mon Dec 18 20:31:51 2017 +0100
----------------------------------------------------------------------
.../imap/processor/AbstractMessageRangeProcessor.java | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/james-project/blob/f7b8a64b/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractMessageRangeProcessor.java
----------------------------------------------------------------------
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractMessageRangeProcessor.java b/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractMessageRangeProcessor.java
index 2c23e95..91df36d 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractMessageRangeProcessor.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractMessageRangeProcessor.java
@@ -20,6 +20,7 @@
package org.apache.james.imap.processor;
import java.util.ArrayList;
+import java.util.Arrays;
import java.util.List;
import org.apache.james.imap.api.ImapCommand;
@@ -44,8 +45,6 @@ import org.apache.james.metrics.api.MetricFactory;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import com.google.common.collect.ImmutableList;
-
public abstract class AbstractMessageRangeProcessor<M extends AbstractMessageRangeRequest> extends AbstractMailboxProcessor<M> {
private static final Logger LOGGER = LoggerFactory.getLogger(AbstractMessageRangeProcessor.class);
@@ -108,14 +107,12 @@ public abstract class AbstractMessageRangeProcessor<M extends AbstractMessageRan
okComplete(command, tag, StatusResponse.ResponseCode.copyUid(uidValidity, idSet, resultUids), responder);
}
} catch (MessageRangeException e) {
- if (LOGGER.isDebugEnabled()) {
- LOGGER.debug(getOperationName() + " failed from mailbox " + currentMailbox.getPath() + " to " + targetMailbox + " for invalid sequence-set " + ImmutableList.copyOf(idSet), e);
- }
+ LOGGER.debug("{} failed from mailbox {} to {} for invalid sequence-set {}",
+ getOperationName(), currentMailbox.getPath(), targetMailbox, Arrays.asList(idSet), e);
taggedBad(command, tag, responder, HumanReadableText.INVALID_MESSAGESET);
} catch (MailboxException e) {
- if (LOGGER.isErrorEnabled()) {
- LOGGER.error(getOperationName() + " failed from mailbox " + currentMailbox.getPath() + " to " + targetMailbox + " for sequence-set " + ImmutableList.copyOf(idSet), e);
- }
+ LOGGER.error("{} failed from mailbox {} to {} for sequence-set {}",
+ getOperationName(), currentMailbox.getPath(), targetMailbox, Arrays.asList(idSet), e);
no(command, tag, responder, HumanReadableText.GENERIC_FAILURE_DURING_PROCESSING);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org