You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by Kaige Liu <ka...@kyligence.io> on 2017/01/22 04:06:00 UTC
Proposal for updating master branch to use HBase 1.x
Hi Folks,
Currently our master branch is based on HBase 0.98. As per discussion here<http://apache-kylin.74782.x6.nabble.com/DISCUSS-Call-the-next-release-v2-0-td6684.html#a6750>, I think it’s the time to change master branch to use HBase 1.x now.
Below changes should be made:
1. Delete master-hbase1.x branch and use master branch instead.
2. merge master-cdh5.7 to master branch(KYLIN-2413<https://issues.apache.org/jira/browse/KYLIN-2413>), master-cdh5.7 should be deleted.
3. new branch master-hbase0.98 will be created to continue supporting HBase 0.98.
Users and developers will be impacted and should choose correct branch according to corresponding Hadoop distros.
1. HBase 0.98 users should use master-hbase0.98 branch
2. Others please use master branch
Developers may need to upgrade your dev environments.
Best regards,
Kaige Liu(刘凯歌)
Mail: kaige.liu@kyligence.io<ma...@kyligence.io>
Shanghai Kyligence Information Technology Co., Ltd
上海市浦东新区亮秀路112号Y1座405室
"Do small things with great love."
Re: Proposal for updating master branch to use HBase 1.x
Posted by hongbin ma <ma...@apache.org>.
+1
With more and more prod env upgrading to hbase 1.x, Kaige's proposal can
help kylin developer to upgrade their development environment( sandbox, qa
cluster, etc), so that the gap between dev env and prod env can be minimal.
A key message here is we're not stopping support for hbase 0.98. we're
merely changing the "default" hbase version.
On Sun, Jan 22, 2017 at 12:06 PM, Kaige Liu <ka...@kyligence.io> wrote:
> Hi Folks,
>
> Currently our master branch is based on HBase 0.98. As per discussion here<
> http://apache-kylin.74782.x6.nabble.com/DISCUSS-
> Call-the-next-release-v2-0-td6684.html#a6750>, I think it’s the time to
> change master branch to use HBase 1.x now.
> Below changes should be made:
>
> 1. Delete master-hbase1.x branch and use master branch instead.
>
> 2. merge master-cdh5.7 to master branch(KYLIN-2413<https://
> issues.apache.org/jira/browse/KYLIN-2413>), master-cdh5.7 should be
> deleted.
>
> 3. new branch master-hbase0.98 will be created to continue
> supporting HBase 0.98.
>
> Users and developers will be impacted and should choose correct branch
> according to corresponding Hadoop distros.
>
> 1. HBase 0.98 users should use master-hbase0.98 branch
>
> 2. Others please use master branch
>
> Developers may need to upgrade your dev environments.
>
> Best regards,
>
> Kaige Liu(刘凯歌)
> Mail: kaige.liu@kyligence.io<ma...@kyligence.io>
> Shanghai Kyligence Information Technology Co., Ltd
> 上海市浦东新区亮秀路112号Y1座405室
>
> "Do small things with great love."
>
>
--
Regards,
*Bin Mahone | 马洪宾*
答复: Proposal for updating master branch to use HBase 1.x
Posted by Fan Xie <fa...@kyligence.io>.
+1
________________________________
发件人: ShaoFeng Shi <sh...@apache.org>
发送时间: 2017年1月23日 11:16:54
收件人: dev
主题: Re: Proposal for updating master branch to use HBase 1.x
+1 We need keep pace with the community; As more and more users are using
HBase 1.x, it is the time for us to switch our main dev and testing
platform to it.
2017-01-23 11:04 GMT+08:00 Dong Li <li...@apache.org>:
> +1, thanks Kaige!
>
>
> Thanks,
> Dong Li
>
> 2017-01-23 10:46 GMT+08:00 Luke Han <lu...@gmail.com>:
>
> > +1, hope all hbase 0.9x users will upgrade to 1.x soon:)
> >
> > Thanks.
> >
> >
> > Best Regards!
> > ---------------------
> >
> > Luke Han
> >
> > On Sun, Jan 22, 2017 at 12:06 PM, Kaige Liu <ka...@kyligence.io>
> > wrote:
> >
> > > Hi Folks,
> > >
> > > Currently our master branch is based on HBase 0.98. As per discussion
> > here<
> > > http://apache-kylin.74782.x6.nabble.com/DISCUSS-
> > > Call-the-next-release-v2-0-td6684.html#a6750>, I think it’s the time
> to
> > > change master branch to use HBase 1.x now.
> > > Below changes should be made:
> > >
> > > 1. Delete master-hbase1.x branch and use master branch instead.
> > >
> > > 2. merge master-cdh5.7 to master branch(KYLIN-2413<https://
> > > issues.apache.org/jira/browse/KYLIN-2413>), master-cdh5.7 should be
> > > deleted.
> > >
> > > 3. new branch master-hbase0.98 will be created to continue
> > > supporting HBase 0.98.
> > >
> > > Users and developers will be impacted and should choose correct branch
> > > according to corresponding Hadoop distros.
> > >
> > > 1. HBase 0.98 users should use master-hbase0.98 branch
> > >
> > > 2. Others please use master branch
> > >
> > > Developers may need to upgrade your dev environments.
> > >
> > > Best regards,
> > >
> > > Kaige Liu(刘凯歌)
> > > Mail: kaige.liu@kyligence.io<ma...@kyligence.io>
> > > Shanghai Kyligence Information Technology Co., Ltd
> > > 上海市浦东新区亮秀路112号Y1座405室
> > >
> > > "Do small things with great love."
> > >
> > >
> >
>
--
Best regards,
Shaofeng Shi 史少锋
Re: Proposal for updating master branch to use HBase 1.x
Posted by Billy Liu <bi...@apache.org>.
+1, nice work.
2017-01-25 15:59 GMT+08:00 Yerui Sun <su...@gmail.com>:
> +1
>
> Use hbase 1.x as default version really make sense.
>
> However, we also should support 0.98 version as past, since upgrading is
> not easy in some production environments.
>
> > 在 2017年1月23日，11:41，nichunen <ni...@mininglamp.com> 写道：
> >
> > +1
> >
> > Hbase 1.x is more commonly used in our clients.
> >
> >
> > George/倪春恩
> >
> > Mobile:+86-13501723787| WeChat:nceecn
> >
> > 北京明略软件系统有限公司（MiningLamp.COM
> > ）
> >
> >
> >
> >
> >
> > 上海市浦东新区晨晖路258号G座iDream张江科创中心C125
> >
> >
> >
> >
> > Room C125#,Intelligent Industrial Park Building G,258#Chenhui Road,
> Pudong District,Shanghai,201203
> >
> >
> >
> >
> >> On Jan 23, 2017, at 11:16 AM, ShaoFeng Shi <sh...@apache.org>
> wrote:
> >>
> >>
> >> +1 We need keep pace with the community; As more and more users are
> using
> >> HBase 1.x, it is the time for us to switch our main dev and testing
> >> platform to it.
> >>
> >>
> >> 2017-01-23 11:04 GMT+08:00 Dong Li <li...@apache.org>:
> >>>
> >>>
> >>> +1, thanks Kaige!
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> Thanks,
> >>> Dong Li
> >>>
> >>>
> >>> 2017-01-23 10:46 GMT+08:00 Luke Han <lu...@gmail.com>:
> >>>>
> >>>>
> >>>> +1, hope all hbase 0.9x users will upgrade to 1.x soon:)
> >>>>
> >>>>
> >>>> Thanks.
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>> Best Regards!
> >>>> ---------------------
> >>>>
> >>>>
> >>>> Luke Han
> >>>>
> >>>>
> >>>> On Sun, Jan 22, 2017 at 12:06 PM, Kaige Liu <ka...@kyligence.io>
> >>>> wrote:
> >>>>>
> >>>>>
> >>>>> Hi Folks,
> >>>>>
> >>>>>
> >>>>> Currently our master branch is based on HBase 0.98. As per discussion
> >>>>>
> >>>>
> >>>> here<
> >>>>>
> >>>>>
> >>>>> http://apache-kylin.74782.x6.nabble.com/DISCUSS-
> >>>>> Call-the-next-release-v2-0-td6684.html#a6750>, I think it’s the time
> >>>>>
> >>>
> >>> to
> >>>>>
> >>>>>
> >>>>> change master branch to use HBase 1.x now.
> >>>>> Below changes should be made:
> >>>>>
> >>>>>
> >>>>> 1. Delete master-hbase1.x branch and use master branch instead.
> >>>>>
> >>>>>
> >>>>> 2. merge master-cdh5.7 to master branch(KYLIN-2413<https://
> >>>>> issues.apache.org/jira/browse/KYLIN-2413>), master-cdh5.7 should be
> >>>>> deleted.
> >>>>>
> >>>>>
> >>>>> 3. new branch master-hbase0.98 will be created to continue
> >>>>> supporting HBase 0.98.
> >>>>>
> >>>>>
> >>>>> Users and developers will be impacted and should choose correct
> branch
> >>>>> according to corresponding Hadoop distros.
> >>>>>
> >>>>>
> >>>>> 1. HBase 0.98 users should use master-hbase0.98 branch
> >>>>>
> >>>>>
> >>>>> 2. Others please use master branch
> >>>>>
> >>>>>
> >>>>> Developers may need to upgrade your dev environments.
> >>>>>
> >>>>>
> >>>>> Best regards,
> >>>>>
> >>>>>
> >>>>> Kaige Liu(刘凯歌)
> >>>>> Mail: kaige.liu@kyligence.io<ma...@kyligence.io>
> >>>>> Shanghai Kyligence Information Technology Co., Ltd
> >>>>> 上海市浦东新区亮秀路112号Y1座405室
> >>>>>
> >>>>>
> >>>>> "Do small things with great love."
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>
> >>>>
> >>>>
> >>>
> >>>
> >>>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >> --
> >> Best regards,
> >>
> >>
> >> Shaofeng Shi 史少锋
> >>
>
>
Re: Proposal for updating master branch to use HBase 1.x
Posted by Yerui Sun <su...@gmail.com>.
+1
Use hbase 1.x as default version really make sense.
However, we also should support 0.98 version as past, since upgrading is not easy in some production environments.
> 在 2017年1月23日，11:41，nichunen <ni...@mininglamp.com> 写道：
>
> +1
>
> Hbase 1.x is more commonly used in our clients.
>
>
> George/倪春恩
>
> Mobile:+86-13501723787| WeChat:nceecn
>
> 北京明略软件系统有限公司（MiningLamp.COM
> ）
>
>
>
>
>
> 上海市浦东新区晨晖路258号G座iDream张江科创中心C125
>
>
>
>
> Room C125#,Intelligent Industrial Park Building G,258#Chenhui Road, Pudong District,Shanghai,201203
>
>
>
>
>> On Jan 23, 2017, at 11:16 AM, ShaoFeng Shi <sh...@apache.org> wrote:
>>
>>
>> +1 We need keep pace with the community; As more and more users are using
>> HBase 1.x, it is the time for us to switch our main dev and testing
>> platform to it.
>>
>>
>> 2017-01-23 11:04 GMT+08:00 Dong Li <li...@apache.org>:
>>>
>>>
>>> +1, thanks Kaige!
>>>
>>>
>>>
>>>
>>>
>>> Thanks,
>>> Dong Li
>>>
>>>
>>> 2017-01-23 10:46 GMT+08:00 Luke Han <lu...@gmail.com>:
>>>>
>>>>
>>>> +1, hope all hbase 0.9x users will upgrade to 1.x soon:)
>>>>
>>>>
>>>> Thanks.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> Best Regards!
>>>> ---------------------
>>>>
>>>>
>>>> Luke Han
>>>>
>>>>
>>>> On Sun, Jan 22, 2017 at 12:06 PM, Kaige Liu <ka...@kyligence.io>
>>>> wrote:
>>>>>
>>>>>
>>>>> Hi Folks,
>>>>>
>>>>>
>>>>> Currently our master branch is based on HBase 0.98. As per discussion
>>>>>
>>>>
>>>> here<
>>>>>
>>>>>
>>>>> http://apache-kylin.74782.x6.nabble.com/DISCUSS-
>>>>> Call-the-next-release-v2-0-td6684.html#a6750>, I think it’s the time
>>>>>
>>>
>>> to
>>>>>
>>>>>
>>>>> change master branch to use HBase 1.x now.
>>>>> Below changes should be made:
>>>>>
>>>>>
>>>>> 1. Delete master-hbase1.x branch and use master branch instead.
>>>>>
>>>>>
>>>>> 2. merge master-cdh5.7 to master branch(KYLIN-2413<https://
>>>>> issues.apache.org/jira/browse/KYLIN-2413>), master-cdh5.7 should be
>>>>> deleted.
>>>>>
>>>>>
>>>>> 3. new branch master-hbase0.98 will be created to continue
>>>>> supporting HBase 0.98.
>>>>>
>>>>>
>>>>> Users and developers will be impacted and should choose correct branch
>>>>> according to corresponding Hadoop distros.
>>>>>
>>>>>
>>>>> 1. HBase 0.98 users should use master-hbase0.98 branch
>>>>>
>>>>>
>>>>> 2. Others please use master branch
>>>>>
>>>>>
>>>>> Developers may need to upgrade your dev environments.
>>>>>
>>>>>
>>>>> Best regards,
>>>>>
>>>>>
>>>>> Kaige Liu(刘凯歌)
>>>>> Mail: kaige.liu@kyligence.io<ma...@kyligence.io>
>>>>> Shanghai Kyligence Information Technology Co., Ltd
>>>>> 上海市浦东新区亮秀路112号Y1座405室
>>>>>
>>>>>
>>>>> "Do small things with great love."
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> --
>> Best regards,
>>
>>
>> Shaofeng Shi 史少锋
>>
Re: Proposal for updating master branch to use HBase 1.x
Posted by nichunen <ni...@mininglamp.com>.
+1
Hbase 1.x is more commonly used in our clients.
George/倪春恩
Mobile:+86-13501723787| WeChat:nceecn
北京明略软件系统有限公司（MiningLamp.COM
）
上海市浦东新区晨晖路258号G座iDream张江科创中心C125
Room C125#,Intelligent Industrial Park Building G,258#Chenhui Road, Pudong District,Shanghai,201203
> On Jan 23, 2017, at 11:16 AM, ShaoFeng Shi <sh...@apache.org> wrote:
>
>
> +1 We need keep pace with the community; As more and more users are using
> HBase 1.x, it is the time for us to switch our main dev and testing
> platform to it.
>
>
> 2017-01-23 11:04 GMT+08:00 Dong Li <li...@apache.org>:
>>
>>
>> +1, thanks Kaige!
>>
>>
>>
>>
>>
>> Thanks,
>> Dong Li
>>
>>
>> 2017-01-23 10:46 GMT+08:00 Luke Han <lu...@gmail.com>:
>>>
>>>
>>> +1, hope all hbase 0.9x users will upgrade to 1.x soon:)
>>>
>>>
>>> Thanks.
>>>
>>>
>>>
>>>
>>>
>>> Best Regards!
>>> ---------------------
>>>
>>>
>>> Luke Han
>>>
>>>
>>> On Sun, Jan 22, 2017 at 12:06 PM, Kaige Liu <ka...@kyligence.io>
>>> wrote:
>>>>
>>>>
>>>> Hi Folks,
>>>>
>>>>
>>>> Currently our master branch is based on HBase 0.98. As per discussion
>>>>
>>>
>>> here<
>>>>
>>>>
>>>> http://apache-kylin.74782.x6.nabble.com/DISCUSS-
>>>> Call-the-next-release-v2-0-td6684.html#a6750>, I think it’s the time
>>>>
>>
>> to
>>>>
>>>>
>>>> change master branch to use HBase 1.x now.
>>>> Below changes should be made:
>>>>
>>>>
>>>> 1. Delete master-hbase1.x branch and use master branch instead.
>>>>
>>>>
>>>> 2. merge master-cdh5.7 to master branch(KYLIN-2413<https://
>>>> issues.apache.org/jira/browse/KYLIN-2413>), master-cdh5.7 should be
>>>> deleted.
>>>>
>>>>
>>>> 3. new branch master-hbase0.98 will be created to continue
>>>> supporting HBase 0.98.
>>>>
>>>>
>>>> Users and developers will be impacted and should choose correct branch
>>>> according to corresponding Hadoop distros.
>>>>
>>>>
>>>> 1. HBase 0.98 users should use master-hbase0.98 branch
>>>>
>>>>
>>>> 2. Others please use master branch
>>>>
>>>>
>>>> Developers may need to upgrade your dev environments.
>>>>
>>>>
>>>> Best regards,
>>>>
>>>>
>>>> Kaige Liu(刘凯歌)
>>>> Mail: kaige.liu@kyligence.io<ma...@kyligence.io>
>>>> Shanghai Kyligence Information Technology Co., Ltd
>>>> 上海市浦东新区亮秀路112号Y1座405室
>>>>
>>>>
>>>> "Do small things with great love."
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>
>>
>>
>
>
>
>
>
>
>
>
>
>
> --
> Best regards,
>
>
> Shaofeng Shi 史少锋
>
Re: Proposal for updating master branch to use HBase 1.x
Posted by ShaoFeng Shi <sh...@apache.org>.
+1 We need keep pace with the community; As more and more users are using
HBase 1.x, it is the time for us to switch our main dev and testing
platform to it.
2017-01-23 11:04 GMT+08:00 Dong Li <li...@apache.org>:
> +1, thanks Kaige!
>
>
> Thanks,
> Dong Li
>
> 2017-01-23 10:46 GMT+08:00 Luke Han <lu...@gmail.com>:
>
> > +1, hope all hbase 0.9x users will upgrade to 1.x soon:)
> >
> > Thanks.
> >
> >
> > Best Regards!
> > ---------------------
> >
> > Luke Han
> >
> > On Sun, Jan 22, 2017 at 12:06 PM, Kaige Liu <ka...@kyligence.io>
> > wrote:
> >
> > > Hi Folks,
> > >
> > > Currently our master branch is based on HBase 0.98. As per discussion
> > here<
> > > http://apache-kylin.74782.x6.nabble.com/DISCUSS-
> > > Call-the-next-release-v2-0-td6684.html#a6750>, I think it’s the time
> to
> > > change master branch to use HBase 1.x now.
> > > Below changes should be made:
> > >
> > > 1. Delete master-hbase1.x branch and use master branch instead.
> > >
> > > 2. merge master-cdh5.7 to master branch(KYLIN-2413<https://
> > > issues.apache.org/jira/browse/KYLIN-2413>), master-cdh5.7 should be
> > > deleted.
> > >
> > > 3. new branch master-hbase0.98 will be created to continue
> > > supporting HBase 0.98.
> > >
> > > Users and developers will be impacted and should choose correct branch
> > > according to corresponding Hadoop distros.
> > >
> > > 1. HBase 0.98 users should use master-hbase0.98 branch
> > >
> > > 2. Others please use master branch
> > >
> > > Developers may need to upgrade your dev environments.
> > >
> > > Best regards,
> > >
> > > Kaige Liu(刘凯歌)
> > > Mail: kaige.liu@kyligence.io<ma...@kyligence.io>
> > > Shanghai Kyligence Information Technology Co., Ltd
> > > 上海市浦东新区亮秀路112号Y1座405室
> > >
> > > "Do small things with great love."
> > >
> > >
> >
>
--
Best regards,
Shaofeng Shi 史少锋
Re: Proposal for updating master branch to use HBase 1.x
Posted by Dong Li <li...@apache.org>.
+1, thanks Kaige!
Thanks,
Dong Li
2017-01-23 10:46 GMT+08:00 Luke Han <lu...@gmail.com>:
> +1, hope all hbase 0.9x users will upgrade to 1.x soon:)
>
> Thanks.
>
>
> Best Regards!
> ---------------------
>
> Luke Han
>
> On Sun, Jan 22, 2017 at 12:06 PM, Kaige Liu <ka...@kyligence.io>
> wrote:
>
> > Hi Folks,
> >
> > Currently our master branch is based on HBase 0.98. As per discussion
> here<
> > http://apache-kylin.74782.x6.nabble.com/DISCUSS-
> > Call-the-next-release-v2-0-td6684.html#a6750>, I think it’s the time to
> > change master branch to use HBase 1.x now.
> > Below changes should be made:
> >
> > 1. Delete master-hbase1.x branch and use master branch instead.
> >
> > 2. merge master-cdh5.7 to master branch(KYLIN-2413<https://
> > issues.apache.org/jira/browse/KYLIN-2413>), master-cdh5.7 should be
> > deleted.
> >
> > 3. new branch master-hbase0.98 will be created to continue
> > supporting HBase 0.98.
> >
> > Users and developers will be impacted and should choose correct branch
> > according to corresponding Hadoop distros.
> >
> > 1. HBase 0.98 users should use master-hbase0.98 branch
> >
> > 2. Others please use master branch
> >
> > Developers may need to upgrade your dev environments.
> >
> > Best regards,
> >
> > Kaige Liu(刘凯歌)
> > Mail: kaige.liu@kyligence.io<ma...@kyligence.io>
> > Shanghai Kyligence Information Technology Co., Ltd
> > 上海市浦东新区亮秀路112号Y1座405室
> >
> > "Do small things with great love."
> >
> >
>
Re: Proposal for updating master branch to use HBase 1.x
Posted by Luke Han <lu...@gmail.com>.
+1, hope all hbase 0.9x users will upgrade to 1.x soon:)
Thanks.
Best Regards!
---------------------
Luke Han
On Sun, Jan 22, 2017 at 12:06 PM, Kaige Liu <ka...@kyligence.io> wrote:
> Hi Folks,
>
> Currently our master branch is based on HBase 0.98. As per discussion here<
> http://apache-kylin.74782.x6.nabble.com/DISCUSS-
> Call-the-next-release-v2-0-td6684.html#a6750>, I think it’s the time to
> change master branch to use HBase 1.x now.
> Below changes should be made:
>
> 1. Delete master-hbase1.x branch and use master branch instead.
>
> 2. merge master-cdh5.7 to master branch(KYLIN-2413<https://
> issues.apache.org/jira/browse/KYLIN-2413>), master-cdh5.7 should be
> deleted.
>
> 3. new branch master-hbase0.98 will be created to continue
> supporting HBase 0.98.
>
> Users and developers will be impacted and should choose correct branch
> according to corresponding Hadoop distros.
>
> 1. HBase 0.98 users should use master-hbase0.98 branch
>
> 2. Others please use master branch
>
> Developers may need to upgrade your dev environments.
>
> Best regards,
>
> Kaige Liu(刘凯歌)
> Mail: kaige.liu@kyligence.io<ma...@kyligence.io>
> Shanghai Kyligence Information Technology Co., Ltd
> 上海市浦东新区亮秀路112号Y1座405室
>
> "Do small things with great love."
>
>
答复: Proposal for updating master branch to use HBase 1.x
Posted by roger shi <ro...@hotmail.com>.
+1, thanks Kaige.
________________________________
发件人: Kaige Liu <ka...@kyligence.io>
发送时间: 2017年1月22日 12:06
收件人: dev@kylin.apache.org
主题: Proposal for updating master branch to use HBase 1.x
Hi Folks,
Currently our master branch is based on HBase 0.98. As per discussion here<http://apache-kylin.74782.x6.nabble.com/DISCUSS-Call-the-next-release-v2-0-td6684.html#a6750>, I think it’s the time to change master branch to use HBase 1.x now.
Below changes should be made:
1. Delete master-hbase1.x branch and use master branch instead.
2. merge master-cdh5.7 to master branch(KYLIN-2413<https://issues.apache.org/jira/browse/KYLIN-2413>), master-cdh5.7 should be deleted.
3. new branch master-hbase0.98 will be created to continue supporting HBase 0.98.
Users and developers will be impacted and should choose correct branch according to corresponding Hadoop distros.
1. HBase 0.98 users should use master-hbase0.98 branch
2. Others please use master branch
Developers may need to upgrade your dev environments.
Best regards,
Kaige Liu(刘凯歌)
Mail: kaige.liu@kyligence.io<ma...@kyligence.io>
Shanghai Kyligence Information Technology Co., Ltd
上海市浦东新区亮秀路112号Y1座405室
"Do small things with great love."