[GitHub] [zookeeper] suhasdantkale commented on a change in pull request #1254: ZOOKEEPER-2164: Quorum members can not rejoin after restart

[GitBox <gi...@apache.org>]

suhasdantkale commented on a change in pull request #1254: ZOOKEEPER-2164: Quorum members can not rejoin after restart
URL: https://github.com/apache/zookeeper/pull/1254#discussion_r380991946
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
 ##########
 @@ -552,10 +577,13 @@ private void handleConnection(Socket sock, DataInputStream din) throws IOExcepti
                 try {
                     InitialMessage init = InitialMessage.parse(protocolVersion, din);
                     sid = init.sid;
-                    electionAddr = new MultipleAddresses(init.electionAddr,
-                        Duration.ofMillis(self.getMultiAddressReachabilityCheckTimeoutMs()));
+                    if (!init.electionAddr.isEmpty()) {
 
 Review comment:
   This is for my understanding only:
   In case of multiple Addresses(if one of the address is the wildcard address and other is not), this will connect to that address. In other words, we will be calling connectOne(sid, electionAddr) and not connectOne(sid).
   Was wondering what if we always called connectOne(sid)?
   I'm just afraid what if we get some address that is not wildcard address but is still NOT connectible. Should we be connecting to the last known address in config for that SID which connectOne(sid) does.
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services