You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2019/05/01 18:29:51 UTC

[Impala-ASF-CR] IMPALA-8269: Refactor authorization test package structure

Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13208


Change subject: IMPALA-8269: Refactor authorization test package structure
......................................................................

IMPALA-8269: Refactor authorization test package structure

This patch refactors authorization test package structure by moving it
to the authorization test package. This patch also renames
CustomClusterResourceAuthorizationProvider to
TestSentryResourceAuthorizationProvider since it is a class that is
specific to Sentry and is only used for testing.

Testing:
- Ran all FE tests
- Ran all E2E authorization tests

Change-Id: I525ff71f63d7c306d82b4c111f98ff327e4a07b3
---
R fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
R fe/src/test/java/org/apache/impala/authorization/AuthorizationTest.java
R fe/src/test/java/org/apache/impala/testutil/TestSentryGroupMapper.java
R fe/src/test/java/org/apache/impala/testutil/TestSentryResourceAuthorizationProvider.java
M fe/src/test/resources/sentry-site.xml.py
M tests/authorization/test_authorization.py
M tests/authorization/test_grant_revoke.py
M tests/authorization/test_owner_privileges.py
M tests/authorization/test_show_grant.py
9 files changed, 38 insertions(+), 40 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/13208/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I525ff71f63d7c306d82b4c111f98ff327e4a07b3
Gerrit-Change-Number: 13208
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>

[Impala-ASF-CR] IMPALA-8269: Refactor authorization test package structure

Posted by "Austin Nobis (Code Review)" <ge...@cloudera.org>.
Austin Nobis has posted comments on this change. ( http://gerrit.cloudera.org:8080/13208 )

Change subject: IMPALA-8269: Refactor authorization test package structure
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I525ff71f63d7c306d82b4c111f98ff327e4a07b3
Gerrit-Change-Number: 13208
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 May 2019 15:08:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8269: Refactor authorization test package structure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13208 )

Change subject: IMPALA-8269: Refactor authorization test package structure
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/3028/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I525ff71f63d7c306d82b4c111f98ff327e4a07b3
Gerrit-Change-Number: 13208
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 May 2019 23:31:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8269: Refactor authorization test package structure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13208 )

Change subject: IMPALA-8269: Refactor authorization test package structure
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13208/2/fe/src/test/java/org/apache/impala/authorization/AuthorizationTest.java
File fe/src/test/java/org/apache/impala/authorization/AuthorizationTest.java:

http://gerrit.cloudera.org:8080/#/c/13208/2/fe/src/test/java/org/apache/impala/authorization/AuthorizationTest.java@20
PS2, Line 20: import static org.apache.hadoop.fs.CommonConfigurationKeysPublic.HADOOP_SECURITY_AUTH_TO_LOCAL;
line too long (95 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/13208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I525ff71f63d7c306d82b4c111f98ff327e4a07b3
Gerrit-Change-Number: 13208
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 May 2019 22:38:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8269: Refactor authorization test package structure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13208 )

Change subject: IMPALA-8269: Refactor authorization test package structure
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I525ff71f63d7c306d82b4c111f98ff327e4a07b3
Gerrit-Change-Number: 13208
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 May 2019 20:40:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8269: Refactor authorization test package structure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13208 )

Change subject: IMPALA-8269: Refactor authorization test package structure
......................................................................

IMPALA-8269: Refactor authorization test package structure

This patch refactors authorization test package structure by moving it
to the authorization test package. This patch also renames
CustomClusterResourceAuthorizationProvider to
TestSentryResourceAuthorizationProvider since it is a class that is
specific to Sentry and is only used for testing.

Testing:
- Ran all FE tests
- Ran all E2E authorization tests

Change-Id: I525ff71f63d7c306d82b4c111f98ff327e4a07b3
Reviewed-on: http://gerrit.cloudera.org:8080/13208
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
R fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
R fe/src/test/java/org/apache/impala/authorization/AuthorizationTest.java
R fe/src/test/java/org/apache/impala/testutil/TestSentryGroupMapper.java
R fe/src/test/java/org/apache/impala/testutil/TestSentryResourceAuthorizationProvider.java
M fe/src/test/resources/sentry-site.xml.py
M tests/authorization/test_authorization.py
M tests/authorization/test_grant_revoke.py
M tests/authorization/test_owner_privileges.py
M tests/authorization/test_show_grant.py
9 files changed, 38 insertions(+), 46 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I525ff71f63d7c306d82b4c111f98ff327e4a07b3
Gerrit-Change-Number: 13208
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8269: Refactor authorization test package structure

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13208 )

Change subject: IMPALA-8269: Refactor authorization test package structure
......................................................................


Patch Set 2: Code-Review+2

+1s from Joe and Austin, bumping it to +2.


-- 
To view, visit http://gerrit.cloudera.org:8080/13208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I525ff71f63d7c306d82b4c111f98ff327e4a07b3
Gerrit-Change-Number: 13208
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 May 2019 15:24:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8269: Refactor authorization test package structure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13208 )

Change subject: IMPALA-8269: Refactor authorization test package structure
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13208/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationTest.java
File fe/src/test/java/org/apache/impala/authorization/AuthorizationTest.java:

http://gerrit.cloudera.org:8080/#/c/13208/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationTest.java@20
PS1, Line 20: import static org.apache.hadoop.fs.CommonConfigurationKeysPublic.HADOOP_SECURITY_AUTH_TO_LOCAL;
line too long (95 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/13208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I525ff71f63d7c306d82b4c111f98ff327e4a07b3
Gerrit-Change-Number: 13208
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 May 2019 18:31:03 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8269: Refactor authorization test package structure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13208 )

Change subject: IMPALA-8269: Refactor authorization test package structure
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4139/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I525ff71f63d7c306d82b4c111f98ff327e4a07b3
Gerrit-Change-Number: 13208
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 May 2019 15:24:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8269: Refactor authorization test package structure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13208 )

Change subject: IMPALA-8269: Refactor authorization test package structure
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I525ff71f63d7c306d82b4c111f98ff327e4a07b3
Gerrit-Change-Number: 13208
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 May 2019 15:24:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8269: Refactor authorization test package structure

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13208 )

Change subject: IMPALA-8269: Refactor authorization test package structure
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

This makes sense to me. I'm willing to bump to +2 if no one else has any comments.

http://gerrit.cloudera.org:8080/#/c/13208/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java:

http://gerrit.cloudera.org:8080/#/c/13208/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@38
PS1, Line 38: import org.apache.impala.authorization.AuthorizationConfig;
            : import org.apache.impala.authorization.AuthorizationFactory;
            : import org.apache.impala.authorization.AuthorizationProvider;
            : import org.apache.impala.authorization.PrivilegeRequest;
            : import org.apache.impala.authorization.User;
            : import org.apache.impala.authorization.AuthorizationException;
Nit: Now that this is in the authorization package, should we remove these?



-- 
To view, visit http://gerrit.cloudera.org:8080/13208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I525ff71f63d7c306d82b4c111f98ff327e4a07b3
Gerrit-Change-Number: 13208
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 May 2019 22:34:04 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8269: Refactor authorization test package structure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13208 )

Change subject: IMPALA-8269: Refactor authorization test package structure
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/3025/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I525ff71f63d7c306d82b4c111f98ff327e4a07b3
Gerrit-Change-Number: 13208
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 May 2019 19:14:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8269: Refactor authorization test package structure

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13208 )

Change subject: IMPALA-8269: Refactor authorization test package structure
......................................................................

IMPALA-8269: Refactor authorization test package structure

This patch refactors authorization test package structure by moving it
to the authorization test package. This patch also renames
CustomClusterResourceAuthorizationProvider to
TestSentryResourceAuthorizationProvider since it is a class that is
specific to Sentry and is only used for testing.

Testing:
- Ran all FE tests
- Ran all E2E authorization tests

Change-Id: I525ff71f63d7c306d82b4c111f98ff327e4a07b3
---
R fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
R fe/src/test/java/org/apache/impala/authorization/AuthorizationTest.java
R fe/src/test/java/org/apache/impala/testutil/TestSentryGroupMapper.java
R fe/src/test/java/org/apache/impala/testutil/TestSentryResourceAuthorizationProvider.java
M fe/src/test/resources/sentry-site.xml.py
M tests/authorization/test_authorization.py
M tests/authorization/test_grant_revoke.py
M tests/authorization/test_owner_privileges.py
M tests/authorization/test_show_grant.py
9 files changed, 38 insertions(+), 46 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/13208/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I525ff71f63d7c306d82b4c111f98ff327e4a07b3
Gerrit-Change-Number: 13208
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>