You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/05/06 00:50:06 UTC
Review Request 59038: Fixed flakiness in
HierarchicalAllocatorTest.NestedRoleDRF.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59038/
-----------------------------------------------------------
Review request for mesos, Anindya Sinha and Michael Park.
Bugs: MESOS-7462
https://issues.apache.org/jira/browse/MESOS-7462
Repository: mesos
Description
-------
Fixed flakiness in HierarchicalAllocatorTest.NestedRoleDRF.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp 33d5c0ea0182e09b3f3f30d20a33d46c23d81697
Diff: https://reviews.apache.org/r/59038/diff/1/
Testing
-------
`./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" --verbose --gtest_repeat=1000 --gtest_break_on_failure .`
Thanks,
Neil Conway
Re: Review Request 59038: Fixed flakiness in
HierarchicalAllocatorTest.NestedRoleDRF.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59038/#review174124
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59038]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 6, 2017, 12:50 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59038/
> -----------------------------------------------------------
>
> (Updated May 6, 2017, 12:50 a.m.)
>
>
> Review request for mesos, Anindya Sinha and Michael Park.
>
>
> Bugs: MESOS-7462
> https://issues.apache.org/jira/browse/MESOS-7462
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed flakiness in HierarchicalAllocatorTest.NestedRoleDRF.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 33d5c0ea0182e09b3f3f30d20a33d46c23d81697
>
>
> Diff: https://reviews.apache.org/r/59038/diff/1/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" --verbose --gtest_repeat=1000 --gtest_break_on_failure .`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 59038: Fixed flakiness in
HierarchicalAllocatorTest.NestedRoleDRF.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59038/
-----------------------------------------------------------
(Updated May 8, 2017, 4:40 p.m.)
Review request for mesos, Anindya Sinha and Michael Park.
Changes
-------
Address review comments.
Bugs: MESOS-7462
https://issues.apache.org/jira/browse/MESOS-7462
Repository: mesos
Description
-------
Fixed flakiness in HierarchicalAllocatorTest.NestedRoleDRF.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 33d5c0ea0182e09b3f3f30d20a33d46c23d81697
Diff: https://reviews.apache.org/r/59038/diff/2/
Changes: https://reviews.apache.org/r/59038/diff/1-2/
Testing
-------
`./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" --verbose --gtest_repeat=1000 --gtest_break_on_failure .`
Thanks,
Neil Conway
Re: Review Request 59038: Fixed flakiness in
HierarchicalAllocatorTest.NestedRoleDRF.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59038/#review174119
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
src/tests/hierarchical_allocator_tests.cpp
Line 745 (original), 745 (patched)
<https://reviews.apache.org/r/59038/#comment247219>
nitpik: Maybe change the order of the comment to reflect that the 2 frameworks are added in roles "a/c" and "d/e" respectively followed by adding of the slave.
src/tests/hierarchical_allocator_tests.cpp
Line 783 (original), 783 (patched)
<https://reviews.apache.org/r/59038/#comment247221>
nitpik: Similar comment as the previous one.
- Anindya Sinha
On May 6, 2017, 12:50 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59038/
> -----------------------------------------------------------
>
> (Updated May 6, 2017, 12:50 a.m.)
>
>
> Review request for mesos, Anindya Sinha and Michael Park.
>
>
> Bugs: MESOS-7462
> https://issues.apache.org/jira/browse/MESOS-7462
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed flakiness in HierarchicalAllocatorTest.NestedRoleDRF.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 33d5c0ea0182e09b3f3f30d20a33d46c23d81697
>
>
> Diff: https://reviews.apache.org/r/59038/diff/1/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" --verbose --gtest_repeat=1000 --gtest_break_on_failure .`
>
>
> Thanks,
>
> Neil Conway
>
>