You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/09/02 02:59:36 UTC
[GitHub] [superset] agl-developer opened a new pull request, #21305: fix(dashboard): Change text and icons in dashboard editmode
agl-developer opened a new pull request, #21305:
URL: https://github.com/apache/superset/pull/21305
### SUMMARY
If user wants to add text to the dashboard, they have to go to "layout components" and choose "markdown". This is super not intuitive for users (findings from Sayya), especially as the icon is not related to the text.
- Change 'Markdown' to 'Text' in edit mode sidebar
- Change default text in markdown editor
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
<img width="1792" alt="Clipboard 2022-28-06 at 1 40 44 PM" src="https://user-images.githubusercontent.com/1985940/188050038-6ea47b49-380d-4f9d-92fd-627b3122357a.png">
After
### TESTING INSTRUCTIONS
- Click on Dashboards on the top left menu bar
- Click on '+ Dashboard' on the top right button
- Select 'Layout Elements' from the right sidebar
- Drag 'Text' to the main editor
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ x ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido merged pull request #21305: fix(dashboard): Change text and icons in dashboard editmode
Posted by GitBox <gi...@apache.org>.
geido merged PR #21305:
URL: https://github.com/apache/superset/pull/21305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21305: fix(dashboard): Change text and icons in dashboard editmode
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21305:
URL: https://github.com/apache/superset/pull/21305#issuecomment-1263659083
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on pull request #21305: fix(dashboard): Change text and icons in dashboard editmode
Posted by GitBox <gi...@apache.org>.
codyml commented on PR #21305:
URL: https://github.com/apache/superset/pull/21305#issuecomment-1260266783
@agl-developer Looks like another Cypress test is broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #21305: fix(dashboard): Change text and icons in dashboard editmode
Posted by GitBox <gi...@apache.org>.
geido commented on PR #21305:
URL: https://github.com/apache/superset/pull/21305#issuecomment-1261072297
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21305: fix(dashboard): Change text and icons in dashboard editmode
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21305:
URL: https://github.com/apache/superset/pull/21305#issuecomment-1261077144
@geido Ephemeral environment spinning up at http://34.217.85.239:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21305: fix(dashboard): Change text and icons in dashboard editmode
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21305:
URL: https://github.com/apache/superset/pull/21305#issuecomment-1235037474
# [Codecov](https://codecov.io/gh/apache/superset/pull/21305?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21305](https://codecov.io/gh/apache/superset/pull/21305?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ad5cebc) into [master](https://codecov.io/gh/apache/superset/commit/222f1e7ea8e95066abd78a06f470d74777f87cc5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (222f1e7) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #21305 +/- ##
=======================================
Coverage 66.43% 66.43%
=======================================
Files 1788 1788
Lines 68276 68276
Branches 7271 7271
=======================================
Hits 45358 45358
Misses 21045 21045
Partials 1873 1873
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.47% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21305?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...oard/components/gridComponents/new/NewMarkdown.jsx](https://codecov.io/gh/apache/superset/pull/21305/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdNYXJrZG93bi5qc3g=) | `0.00% <ø> (ø)` | |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/superset/pull/21305/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `72.36% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org