You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sqoop.apache.org by rj...@gmail.com on 2013/01/05 22:51:32 UTC

Review Request: Client shell variable substitution for recent commands

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8842/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

execute() method is replaced with executeCommand() method in all Command classes. executed() method overrided in SqoopCommand which resolves the variables and then executes the command.


This addresses bug SQOOP-811.
    https://issues.apache.org/jira/browse/SQOOP-811


Diffs
-----

  client/src/main/java/org/apache/sqoop/client/shell/CloneCommand.java 827d168 
  client/src/main/java/org/apache/sqoop/client/shell/CreateCommand.java ad4d8fd 
  client/src/main/java/org/apache/sqoop/client/shell/DeleteCommand.java 5ab6495 
  client/src/main/java/org/apache/sqoop/client/shell/SetCommand.java fb6e8c8 
  client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java efbb8f2 
  client/src/main/java/org/apache/sqoop/client/shell/SqoopCommand.java d818353 
  client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 2e1fb03 
  client/src/main/java/org/apache/sqoop/client/shell/UpdateCommand.java d73b40e 

Diff: https://reviews.apache.org/r/8842/diff/


Testing
-------


Thanks,

vasanthkumar

Re: Review Request: Client shell variable substitution for recent commands

Posted by Jarek Cecho <ja...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8842/#review15100
-----------------------------------------------------------

Ship it!


Hi Vasanth,
thank you very much for noticing this! The changes looks good to me, I just have couple of nits. Feel free to upload fixed patch directly to JIRA without another round on review board! I'll be more than happy to commit it.


client/src/main/java/org/apache/sqoop/client/shell/SqoopCommand.java
<https://reviews.apache.org/r/8842/#comment32691>

    Nit: Trailing whitespaces



client/src/main/java/org/apache/sqoop/client/shell/SqoopCommand.java
<https://reviews.apache.org/r/8842/#comment32692>

    Nit: Trailing whitespaces



client/src/main/java/org/apache/sqoop/client/shell/SqoopCommand.java
<https://reviews.apache.org/r/8842/#comment32693>

    Nit: Trailing whitespaces


Jarcec

- Jarek Cecho


On Jan. 5, 2013, 9:51 p.m., vasanthkumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8842/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2013, 9:51 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> execute() method is replaced with executeCommand() method in all Command classes. executed() method overrided in SqoopCommand which resolves the variables and then executes the command.
> 
> 
> This addresses bug SQOOP-811.
>     https://issues.apache.org/jira/browse/SQOOP-811
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/shell/CloneCommand.java 827d168 
>   client/src/main/java/org/apache/sqoop/client/shell/CreateCommand.java ad4d8fd 
>   client/src/main/java/org/apache/sqoop/client/shell/DeleteCommand.java 5ab6495 
>   client/src/main/java/org/apache/sqoop/client/shell/SetCommand.java fb6e8c8 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java efbb8f2 
>   client/src/main/java/org/apache/sqoop/client/shell/SqoopCommand.java d818353 
>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 2e1fb03 
>   client/src/main/java/org/apache/sqoop/client/shell/UpdateCommand.java d73b40e 
> 
> Diff: https://reviews.apache.org/r/8842/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> vasanthkumar
> 
>