You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2023/01/20 03:27:33 UTC
[GitHub] [incubator-devlake] keon94 opened a new issue, #4241: [Bug][UI] The "Tasks Completed" counter can exceed the total
keon94 opened a new issue, #4241:
URL: https://github.com/apache/incubator-devlake/issues/4241
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
### What happened
Rerunning a task caused the counter to go over the total task count.
### What do you expect to happen
The counter should not exceed the total task count.
### How to reproduce
Pick any pipeline and run it. Then rerun any of its tasks, and this will happen. I tried Jenkins and Github.
### Anything else
I believe the correct behavior should be to only change the counter if a previously failed job succeeds (+1) or a previously successful job fails (-1). Otherwise, leave it alone.
### Version
main
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #4241: [Bug][UI] The "Tasks Completed" counter can exceed the total
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4241:
URL: https://github.com/apache/incubator-devlake/issues/4241#issuecomment-1646699829
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #4241: [Bug][UI] The "Tasks Completed" counter can exceed the total
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4241:
URL: https://github.com/apache/incubator-devlake/issues/4241#issuecomment-1597901409
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #4241: [Bug][UI] The "Tasks Completed" counter can exceed the total
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4241:
URL: https://github.com/apache/incubator-devlake/issues/4241#issuecomment-1452824616
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Startrekzky commented on issue #4241: [Bug][UI] The "Tasks Completed" counter can exceed the total
Posted by "Startrekzky (via GitHub)" <gi...@apache.org>.
Startrekzky commented on issue #4241:
URL: https://github.com/apache/incubator-devlake/issues/4241#issuecomment-1547396507
This is not urgent so I removed it from the milestone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #4241: [Bug][UI] The "Tasks Completed" counter can exceed the total
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on issue #4241:
URL: https://github.com/apache/incubator-devlake/issues/4241#issuecomment-1407271743
@Startrekzky please take a look at this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #4241: [Bug][UI] The "Tasks Completed" counter can exceed the total
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4241:
URL: https://github.com/apache/incubator-devlake/issues/4241#issuecomment-1547041794
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Startrekzky commented on issue #4241: [Bug][UI] The "Tasks Completed" counter can exceed the total
Posted by "Startrekzky (via GitHub)" <gi...@apache.org>.
Startrekzky commented on issue #4241:
URL: https://github.com/apache/incubator-devlake/issues/4241#issuecomment-1407634324
@keon94 @klesh `Task Completed` is for users to understand if `all tasks of a pipeline have been successfully finished`, rather than the actual number of tasks being successfully run. According to this:
- The denominator should be the number of a pipeline's default tasks
- The numerator should be the successful tasks of a pipeline's default tasks (if rerunning a default task, the new task and its original copy should be considered as the same task)
For example, if a pipeline has 7 default tasks. Then the denominator should always be 7。
- If 2 tasks failed, then the task completed should be 5/7. When rerunning the 2 failed tasks and 1 succeeds, the number will be 6/7.
- If 7 tasks all passed, then the task completed should be 7/7. When rerunning 1 task and it succeeds, the number will still be 7/7.
I hope it makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #4241: [Bug][UI] The "Tasks Completed" counter can exceed the total
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4241:
URL: https://github.com/apache/incubator-devlake/issues/4241#issuecomment-1661274891
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] closed issue #4241: [Bug][UI] The "Tasks Completed" counter can exceed the total
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #4241: [Bug][UI] The "Tasks Completed" counter can exceed the total
URL: https://github.com/apache/incubator-devlake/issues/4241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org