[GitHub] [apisix] kwanhur commented on a change in pull request #6246: ci: runner shell sudo doesn't affect redirects SC2024

[GitBox <gi...@apache.org>]

kwanhur commented on a change in pull request #6246:
URL: https://github.com/apache/apisix/pull/6246#discussion_r800192300



##########
File path: ci/linux_apisix_current_luarocks_runner.sh
##########
@@ -33,8 +33,8 @@ script() {
     sudo rm -rf /usr/local/share/lua/5.1/apisix
 
     # install APISIX with local version
-    sudo luarocks install rockspec/apisix-master-0.rockspec --only-deps > build.log 2>&1 || (cat build.log && exit 1)
-    sudo luarocks make rockspec/apisix-master-0.rockspec > build.log 2>&1 || (cat build.log && exit 1)
+    sudo luarocks install rockspec/apisix-master-0.rockspec --only-deps | sudo tee build.log > /dev/null 2>&1 || (cat build.log && exit 1)

Review comment:
       The original redirects stdout into `build.log`, it isn't recommended for using `sudo`.
   
   If it needs log into `build.log`, suggest using `tee` to make it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org