You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by David Mollitor <da...@gmail.com> on 2021/12/09 17:21:42 UTC

Review Request 73751: RANGER-3545: Remove Logger Checks for Info Enabled

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73751/
-----------------------------------------------------------

Review request for ranger.


Repository: ranger


Description
-------

There are some places in the code that check for isInfoEnabled() on loggers.  This is superfluous as almost always INFO is enabled and it's also no consistent with the rest of the codebase that does not have these guards.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerConfiguration.java d837a69b6 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java e998944a5 
  ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java 401b3f01b 


Diff: https://reviews.apache.org/r/73751/diff/1/


Testing
-------


Thanks,

David Mollitor

Re: Review Request 73751: RANGER-3545: Remove Logger Checks for Info Enabled

Posted by Pradeep Agrawal <pr...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73751/#review224395
-----------------------------------------------------------



Please close the RR

- Pradeep Agrawal


On Dec. 9, 2021, 5:21 p.m., David Mollitor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73751/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2021, 5:21 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> There are some places in the code that check for isInfoEnabled() on loggers.  This is superfluous as almost always INFO is enabled and it's also no consistent with the rest of the codebase that does not have these guards.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerConfiguration.java d837a69b6 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java e998944a5 
>   ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java 401b3f01b 
> 
> 
> Diff: https://reviews.apache.org/r/73751/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Mollitor
> 
>