[GitHub] drcrallen edited a comment on issue #5921: Support annotation binding in Druid extensions

[GitBox <gi...@apache.org>]

drcrallen edited a comment on issue #5921: Support annotation binding in Druid extensions
URL: https://github.com/apache/incubator-druid/pull/5921#issuecomment-405695124
 
 
   The jackson injector we use was written before the guice module was available IIRC. It is worth replacing with the general injectables module for guice probably, but I don't think that solves the problem you are finding.
   
   If you are having binding problems in extensions then there is something else going on.
   
   Specifically the problem I could see happening is the following:
   
   You have extension A which defines an annotation. Extension B also uses the annotation. Extension A uses bound annotations in its code path, Extension B binds new implementations to the annotation... but due to classloader isolation, they are *NOT* actually the same class. As such the ones bound in Extension B are never used as an "annotated binding" in Extension A.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
For additional commands, e-mail: dev-help@druid.apache.org