You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "ryan rawson (JIRA)" <ji...@apache.org> on 2009/06/21 05:44:07 UTC
[jira] Created: (HBASE-1558) add/delete use
'HConstants.LATEST_TIMESTAMP' but no one translates that into 'now'
add/delete use 'HConstants.LATEST_TIMESTAMP' but no one translates that into 'now'
----------------------------------------------------------------------------------
Key: HBASE-1558
URL: https://issues.apache.org/jira/browse/HBASE-1558
Project: Hadoop HBase
Issue Type: Bug
Components: client, regionserver
Affects Versions: 0.20.0
Reporter: ryan rawson
Priority: Blocker
Fix For: 0.20.0
This one is huge guys, when you are deleting columns or families, the Delete uses "Long.MAX_VALUE" but no one translates it into 'System.currentTimeMillis()'. Same for Puts. It's a wonder anything works actually!
The question is: should the client set the TS to 'now' or the server? My guess is the server....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1558) deletes use
'HConstants.LATEST_TIMESTAMP' but no one translates that into 'now'
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1558:
-------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Thanks Ryan.
> deletes use 'HConstants.LATEST_TIMESTAMP' but no one translates that into 'now'
> -------------------------------------------------------------------------------
>
> Key: HBASE-1558
> URL: https://issues.apache.org/jira/browse/HBASE-1558
> Project: Hadoop HBase
> Issue Type: Bug
> Components: client, regionserver
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HBASE-1558-v2.patch, HBASE-1558.patch
>
>
> Deletes don't update MAX_TIMESTAMP -> now like puts do.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1558) deletes use
'HConstants.LATEST_TIMESTAMP' but no one translates that into 'now'
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722384#action_12722384 ]
Andrew Purtell commented on HBASE-1558:
---------------------------------------
+1, patch v2.
> deletes use 'HConstants.LATEST_TIMESTAMP' but no one translates that into 'now'
> -------------------------------------------------------------------------------
>
> Key: HBASE-1558
> URL: https://issues.apache.org/jira/browse/HBASE-1558
> Project: Hadoop HBase
> Issue Type: Bug
> Components: client, regionserver
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HBASE-1558-v2.patch, HBASE-1558.patch
>
>
> Deletes don't update MAX_TIMESTAMP -> now like puts do.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1558) deletes use
'HConstants.LATEST_TIMESTAMP' but no one translates that into 'now'
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1558:
-------------------------------
Status: Patch Available (was: Open)
> deletes use 'HConstants.LATEST_TIMESTAMP' but no one translates that into 'now'
> -------------------------------------------------------------------------------
>
> Key: HBASE-1558
> URL: https://issues.apache.org/jira/browse/HBASE-1558
> Project: Hadoop HBase
> Issue Type: Bug
> Components: client, regionserver
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HBASE-1558-v2.patch, HBASE-1558.patch
>
>
> Deletes don't update MAX_TIMESTAMP -> now like puts do.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1558) deletes use
'HConstants.LATEST_TIMESTAMP' but no one translates that into 'now'
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722298#action_12722298 ]
ryan rawson commented on HBASE-1558:
------------------------------------
it needs to be done in HRegion so we can put the proper TS into the WAL.
> deletes use 'HConstants.LATEST_TIMESTAMP' but no one translates that into 'now'
> -------------------------------------------------------------------------------
>
> Key: HBASE-1558
> URL: https://issues.apache.org/jira/browse/HBASE-1558
> Project: Hadoop HBase
> Issue Type: Bug
> Components: client, regionserver
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Priority: Blocker
> Fix For: 0.20.0
>
>
> Deletes don't update MAX_TIMESTAMP -> now like puts do.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1558) deletes use
'HConstants.LATEST_TIMESTAMP' but no one translates that into 'now'
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1558:
-------------------------------
Attachment: HBASE-1558.patch
here's a prototype fix, but we need tests.
> deletes use 'HConstants.LATEST_TIMESTAMP' but no one translates that into 'now'
> -------------------------------------------------------------------------------
>
> Key: HBASE-1558
> URL: https://issues.apache.org/jira/browse/HBASE-1558
> Project: Hadoop HBase
> Issue Type: Bug
> Components: client, regionserver
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HBASE-1558.patch
>
>
> Deletes don't update MAX_TIMESTAMP -> now like puts do.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1558) deletes use
'HConstants.LATEST_TIMESTAMP' but no one translates that into 'now'
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1558:
-------------------------------
Attachment: HBASE-1558-v2.patch
Here is a version with tests
> deletes use 'HConstants.LATEST_TIMESTAMP' but no one translates that into 'now'
> -------------------------------------------------------------------------------
>
> Key: HBASE-1558
> URL: https://issues.apache.org/jira/browse/HBASE-1558
> Project: Hadoop HBase
> Issue Type: Bug
> Components: client, regionserver
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HBASE-1558-v2.patch, HBASE-1558.patch
>
>
> Deletes don't update MAX_TIMESTAMP -> now like puts do.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1558) deletes use
'HConstants.LATEST_TIMESTAMP' but no one translates that into 'now'
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1558:
-------------------------------
Description: Deletes don't update MAX_TIMESTAMP -> now like puts do. (was: This one is huge guys, when you are deleting columns or families, the Delete uses "Long.MAX_VALUE" but no one translates it into 'System.currentTimeMillis()'. Same for Puts. It's a wonder anything works actually!
The question is: should the client set the TS to 'now' or the server? My guess is the server....)
Summary: deletes use 'HConstants.LATEST_TIMESTAMP' but no one translates that into 'now' (was: add/delete use 'HConstants.LATEST_TIMESTAMP' but no one translates that into 'now')
> deletes use 'HConstants.LATEST_TIMESTAMP' but no one translates that into 'now'
> -------------------------------------------------------------------------------
>
> Key: HBASE-1558
> URL: https://issues.apache.org/jira/browse/HBASE-1558
> Project: Hadoop HBase
> Issue Type: Bug
> Components: client, regionserver
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Priority: Blocker
> Fix For: 0.20.0
>
>
> Deletes don't update MAX_TIMESTAMP -> now like puts do.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.