[GitHub] [ignite-3] sashapolo commented on a change in pull request #367: IGNITE-15646 ConcurrentHashMapStorage moved to test package.

[GitBox <gi...@apache.org>]

sashapolo commented on a change in pull request #367:
URL: https://github.com/apache/ignite-3/pull/367#discussion_r719274150



##########
File path: modules/table/src/integrationTest/java/org/apache/ignite/distributed/ITTablePersistenceTest.java
##########
@@ -125,14 +130,18 @@
 
     /** {@inheritDoc} */
     @Override public Path getListenerPersistencePath(PartitionListener listener) {
-        return ((RocksDbStorage) listener.getStorage()).getDbPath();
+        return paths.get(listener);
     }
 
     /** {@inheritDoc} */
     @Override public RaftGroupListener createListener(Path workDir) {
-        return new PartitionListener(
-            new RocksDbStorage(workDir.resolve(UUID.randomUUID().toString()), ByteBuffer::compareTo)
-        );
+        Path tableDir = workDir.resolve(UUID.randomUUID().toString());

Review comment:
       Can we update the parent class, so that we can get rid of this fake directory?

##########
File path: modules/table/src/integrationTest/java/org/apache/ignite/distributed/ITTablePersistenceTest.java
##########
@@ -41,7 +43,7 @@
 import org.apache.ignite.raft.client.service.RaftGroupService;
 
 /**
- * Persistent (rocksdb-based) partitions raft group snapshots tests.
+ * Persistent partitions raft group snapshots tests.

Review comment:
       If this test tests some persistent properties, why do we switch to an in-memory implementation?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org