You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2023/01/27 16:07:40 UTC

[GitHub] [doris] morningman commented on a diff in pull request #16107: [Chore](EditLog) refine error output on edit log

morningman commented on code in PR #16107:
URL: https://github.com/apache/doris/pull/16107#discussion_r1089138657


##########
fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java:
##########
@@ -994,9 +994,10 @@ public static void loadJournal(Env env, JournalEntity journal) {
              * log a warning here to debug when happens. This could happen to other meta
              * like DB.
              */
-            LOG.warn("[INCONSISTENT META] replay failed {}: {}", journal, e.getMessage(), e);
+            LOG.warn("[INCONSISTENT META] replay failed {}: {}", journal, e.getMessage());
         } catch (Exception e) {
-            LOG.error("Operation Type {}", opCode, e);
+            LOG.error("Operation Type {}: {}", opCode, e.getMessage());
+            e.printStackTrace();

Review Comment:
   > 
   
   @ByteYue could you please submit a PR to add `-XX:-OmitStackTraceInFastThrow`? I think this is necessary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org