You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2016/08/05 15:37:29 UTC
[GitHub] nifi pull request #794: UI inconsistencies
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/794
UI inconsistencies
NiFi-2468:
- Addressing numerous inconsistencies throughout the UI (button placement above tables, timestamp styles, etc)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-2468
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/794.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #794
----
commit c68c4da419574fbbe42f8289c94c6a33543840e6
Author: Scott Aslan <ja...@hortonworks.com>
Date: 2016-08-03T21:19:50Z
addressing some inconsistencies
commit cfb07fba16ee57d3d53216ed35fa9aeacd1ec1d2
Author: Matt Gilman <ma...@gmail.com>
Date: 2016-08-05T15:35:28Z
NIFI-2468:
- Addressing numerous inconsistencies throughout the UI (button placement above tables, timestamp styles, etc)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #794: UI inconsistencies
Posted by moranr <gi...@git.apache.org>.
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/794
Looks good @mcgilman . Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #794: UI inconsistencies
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/794
Thanks @moranr. Will update shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #794: UI inconsistencies
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/794
Squashed, merged, closed. @scottyaslan got the credit in the commit. Sorry to ruin your stats, @mcgilman.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #794: UI inconsistencies
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/794
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #794: UI inconsistencies
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/794
I'm added another commit to address @moranr comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #794: UI inconsistencies
Posted by moranr <gi...@git.apache.org>.
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/794
Overall it looks good @mcgilman but I think one item was overlooked. For Process Group Config, the Add Controller Service button is still on top of the tabs. Just need to move below like the others.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #794: UI inconsistencies
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/794
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---