Re: [PR] IGNITE-26315 Fix race between increasing partition generation and performing write operations to it [ignite-3]

["sashapolo (via GitHub)" <gi...@apache.org>]

sashapolo commented on code in PR #6502:
URL: https://github.com/apache/ignite-3/pull/6502#discussion_r2309784086


##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/replacement/DelayedDirtyPageWrite.java:
##########
@@ -134,7 +141,9 @@ public void flushCopiedPageIfExists() throws IgniteInternalCheckedException {
 
         Throwable errorOnWrite = null;
 
-        checkpointPages.blockPartitionDestruction(GroupPartitionId.convert(fullPageId));
+        Lock partitionDesctructionLock = partitionDestructionLockManager.destructionLock(GroupPartitionId.convert(fullPageId)).readLock();

Review Comment:
   ```suggestion
           Lock partitionDestructionLock = partitionDestructionLockManager.destructionLock(GroupPartitionId.convert(fullPageId)).readLock();
   ```



##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointPagesWriter.java:
##########
@@ -267,6 +276,8 @@ private Map<PersistentPageMemory, List<DirtyFullPageId>> writeRetryDirtyPages(
 
             GroupPartitionId partitionId = null;
 
+            Lock partitionDesctructionLock = null;

Review Comment:
   ```suggestion
               Lock partitionDestructionLock = null;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org