[GitHub] [incubator-superset] craig-rueda commented on a change in pull request #8775: Splitting up some of the Docker build steps

[GitBox <gi...@apache.org>]

craig-rueda commented on a change in pull request #8775: Splitting up some of the Docker build steps
URL: https://github.com/apache/incubator-superset/pull/8775#discussion_r354592585
 
 

 ##########
 File path: Dockerfile
 ##########
 @@ -26,24 +29,35 @@ RUN mkdir /app \
             libpq-dev \
         && rm -rf /var/lib/apt/lists/*
 
-COPY ./requirements.txt ./docker/requirements-extra.txt ./setup.py ./MANIFEST.in ./README.md ./app/
-COPY superset /app/superset
-
+# First, we just wanna install requirements, which will allow us to utilize the cache
+# in order to only build iff requirements change
 
 Review comment:
   Fixed `iff` -> `if and only if`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org