You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/26 09:38:13 UTC
[GitHub] [pulsar] mattisonchao opened a new pull request #11111: [ Tests ] Add new unit test for ReponseHandlerFilter
mattisonchao opened a new pull request #11111:
URL: https://github.com/apache/pulsar/pull/11111
### Motivation
Add test.
### Modifications
- Add new unit test for ReponseHandlerFilter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao closed pull request #11111: [ Tests ] Add new unit test for ReponseHandlerFilter
Posted by GitBox <gi...@apache.org>.
mattisonchao closed pull request #11111:
URL: https://github.com/apache/pulsar/pull/11111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #11111: [ Tests ] Add new unit test for ReponseHandlerFilter
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #11111:
URL: https://github.com/apache/pulsar/pull/11111#discussion_r660563575
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/web/ResponseHandlerFilterTest.java
##########
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.broker.web;
+
+import static org.mockito.Mockito.*;
+import static org.testng.Assert.*;
Review comment:
Please avoid using star import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #11111: [ Tests ] Add new unit test for ReponseHandlerFilter
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #11111:
URL: https://github.com/apache/pulsar/pull/11111#issuecomment-874643324
I'm not sure why we need this unit test. The unit tests in Pulsar may be enough? Or we could move the Pulsar tests to here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a change in pull request #11111: [ Tests ] Add new unit test for ReponseHandlerFilter
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on a change in pull request #11111:
URL: https://github.com/apache/pulsar/pull/11111#discussion_r660564083
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/web/ResponseHandlerFilterTest.java
##########
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.broker.web;
+
+import static org.mockito.Mockito.*;
+import static org.testng.Assert.*;
Review comment:
Okay, I will fix it ASAP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #11111: [ Tests ] Add new unit test for ReponseHandlerFilter
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #11111:
URL: https://github.com/apache/pulsar/pull/11111#discussion_r660563575
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/web/ResponseHandlerFilterTest.java
##########
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.broker.web;
+
+import static org.mockito.Mockito.*;
+import static org.testng.Assert.*;
Review comment:
Please avoid using star import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #11111: [ Tests ] Add new unit test for ReponseHandlerFilter
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #11111:
URL: https://github.com/apache/pulsar/pull/11111#issuecomment-872221030
@gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a change in pull request #11111: [ Tests ] Add new unit test for ReponseHandlerFilter
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on a change in pull request #11111:
URL: https://github.com/apache/pulsar/pull/11111#discussion_r660564083
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/web/ResponseHandlerFilterTest.java
##########
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.broker.web;
+
+import static org.mockito.Mockito.*;
+import static org.testng.Assert.*;
Review comment:
Okay, I will fix it ASAP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #11111: [ Tests ] Add new unit test for ReponseHandlerFilter
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #11111:
URL: https://github.com/apache/pulsar/pull/11111#issuecomment-874643324
I'm not sure why we need this unit test. The unit tests in Pulsar may be enough? Or we could move the Pulsar tests to here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org