You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/06/09 14:49:08 UTC

[GitHub] [orc] pgaref edited a comment on pull request #714: ORC-812: Simplify getClosestBufferSize in Writer

pgaref edited a comment on pull request #714:
URL: https://github.com/apache/orc/pull/714#issuecomment-857748790


   > 3
   
   I probably did not explain this properly, my question was if we actually need the -1 deduction since are already rounding up on the next power or 2.  Taking another look this takes care of the equality case ( e.g., 32KB does not need any rounding as it will be twice as large).
   
   +1 on the existing changes
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org