You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2024/11/21 17:57:37 UTC

[Impala-ASF-CR] IMPALA-13561: test read mixed format position deletes fails with newer Hive versions

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22089


Change subject: IMPALA-13561: test_read_mixed_format_position_deletes fails with newer Hive versions
......................................................................

IMPALA-13561: test_read_mixed_format_position_deletes fails with newer Hive versions

test_read_mixed_format_position_deletes can fail with newer Hive
versions as they name files differently. E.g. data files don't have
"data" in their filenames anymore.

This patch updates the test file.

Change-Id: Ic1dc5e62f5b8c0a7aaa54939831561ed5490b6db
---
M testdata/workloads/functional-query/queries/QueryTest/iceberg-mixed-format-position-deletes.test
1 file changed, 10 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/22089/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1dc5e62f5b8c0a7aaa54939831561ed5490b6db
Gerrit-Change-Number: 22089
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-13561: test read mixed format position deletes fails with newer Hive versions

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22089 )

Change subject: IMPALA-13561: test_read_mixed_format_position_deletes fails with newer Hive versions
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1dc5e62f5b8c0a7aaa54939831561ed5490b6db
Gerrit-Change-Number: 22089
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2024 14:37:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13561: test read mixed format position deletes fails with newer Hive versions

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22089 )

Change subject: IMPALA-13561: test_read_mixed_format_position_deletes fails with newer Hive versions
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1dc5e62f5b8c0a7aaa54939831561ed5490b6db
Gerrit-Change-Number: 22089
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2024 08:58:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13561: test read mixed format position deletes fails with newer Hive versions

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22089 )

Change subject: IMPALA-13561: test_read_mixed_format_position_deletes fails with newer Hive versions
......................................................................

IMPALA-13561: test_read_mixed_format_position_deletes fails with newer Hive versions

test_read_mixed_format_position_deletes can fail with newer Hive
versions as they name files differently. E.g. data files don't have
"data" in their filenames anymore.

This patch updates the test file.

Change-Id: Ic1dc5e62f5b8c0a7aaa54939831561ed5490b6db
Reviewed-on: http://gerrit.cloudera.org:8080/22089
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/iceberg-mixed-format-position-deletes.test
1 file changed, 10 insertions(+), 10 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1dc5e62f5b8c0a7aaa54939831561ed5490b6db
Gerrit-Change-Number: 22089
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>

[Impala-ASF-CR] IMPALA-13561: test read mixed format position deletes fails with newer Hive versions

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/22089 )

Change subject: IMPALA-13561: test_read_mixed_format_position_deletes fails with newer Hive versions
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1dc5e62f5b8c0a7aaa54939831561ed5490b6db
Gerrit-Change-Number: 22089
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 22:27:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13561: test read mixed format position deletes fails with newer Hive versions

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22089 )

Change subject: IMPALA-13561: test_read_mixed_format_position_deletes fails with newer Hive versions
......................................................................

IMPALA-13561: test_read_mixed_format_position_deletes fails with newer Hive versions

test_read_mixed_format_position_deletes can fail with newer Hive
versions as they name files differently. E.g. data files don't have
"data" in their filenames anymore.

This patch updates the test file.

Change-Id: Ic1dc5e62f5b8c0a7aaa54939831561ed5490b6db
Reviewed-on: http://gerrit.cloudera.org:8080/22089
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/iceberg-mixed-format-position-deletes.test
1 file changed, 10 insertions(+), 10 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1dc5e62f5b8c0a7aaa54939831561ed5490b6db
Gerrit-Change-Number: 22089
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>

[Impala-ASF-CR] IMPALA-13561: test read mixed format position deletes fails with newer Hive versions

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22089 )

Change subject: IMPALA-13561: test_read_mixed_format_position_deletes fails with newer Hive versions
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/17539/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1dc5e62f5b8c0a7aaa54939831561ed5490b6db
Gerrit-Change-Number: 22089
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 18:24:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13561: test read mixed format position deletes fails with newer Hive versions

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22089 )

Change subject: IMPALA-13561: test_read_mixed_format_position_deletes fails with newer Hive versions
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11164/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1dc5e62f5b8c0a7aaa54939831561ed5490b6db
Gerrit-Change-Number: 22089
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2024 08:58:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13561: test read mixed format position deletes fails with newer Hive versions

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22089 )

Change subject: IMPALA-13561: test_read_mixed_format_position_deletes fails with newer Hive versions
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1dc5e62f5b8c0a7aaa54939831561ed5490b6db
Gerrit-Change-Number: 22089
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 19:40:56 +0000
Gerrit-HasComments: No