You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/02/24 07:25:49 UTC

[GitHub] [guacamole-server] oxcrag commented on a change in pull request #258: GUACAMOLE-968: Add Norwegian keymap

oxcrag commented on a change in pull request #258: GUACAMOLE-968: Add Norwegian keymap
URL: https://github.com/apache/guacamole-server/pull/258#discussion_r383111482
 
 

 ##########
 File path: src/protocols/rdp/Makefile.am
 ##########
 @@ -224,6 +224,7 @@ BUILT_SOURCES =                         \
 rdp_keymaps =                                \
     $(srcdir)/keymaps/base.keymap            \
     $(srcdir)/keymaps/failsafe.keymap        \
+    $(srcdir)/keymaps/da_dk_qwerty.keymap    \
 
 Review comment:
   No, I just figured I'd order the rest of the keymaps in the code block while I put the Norwegian one in its correct place. On the contrary I was unsure about whether to move `failsafe.keymap` to its alphabetical position and decided against it, since it could be argued to be a special case that perhaps deserves special visibility. As you see, I just moved the Danish keymap from directly below the Swedish to its more alphabetically correct position above the German one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services