You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/01/22 22:03:36 UTC
[GitHub] [accumulo] ctubbsii opened a new pull request #1879: Include stack trace in log for DfsLogger.fail()
ctubbsii opened a new pull request #1879:
URL: https://github.com/apache/accumulo/pull/1879
Ensure the DfsLogger.fail() method includes the stack trace for the
exception that occurred, in case something happens and it doesn't get
wrapped and rethrown later. Also, use slf4j substitution syntax.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #1879: Include stack trace in log for DfsLogger.fail()
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #1879:
URL: https://github.com/apache/accumulo/pull/1879
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on a change in pull request #1879: Include stack trace in log for DfsLogger.fail()
Posted by GitBox <gi...@apache.org>.
EdColeman commented on a change in pull request #1879:
URL: https://github.com/apache/accumulo/pull/1879#discussion_r563424259
##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
##########
@@ -224,7 +224,7 @@ public void run() {
}
private void fail(ArrayList<DfsLogger.LogWork> work, Exception ex, String why) {
- log.warn("Exception " + why + " " + ex);
+ log.warn("Exception {} {}", why, ex, ex);
Review comment:
I think you have an extra ex - or you need another {}.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on a change in pull request #1879: Include stack trace in log for DfsLogger.fail()
Posted by GitBox <gi...@apache.org>.
EdColeman commented on a change in pull request #1879:
URL: https://github.com/apache/accumulo/pull/1879#discussion_r563424259
##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
##########
@@ -224,7 +224,7 @@ public void run() {
}
private void fail(ArrayList<DfsLogger.LogWork> work, Exception ex, String why) {
- log.warn("Exception " + why + " " + ex);
+ log.warn("Exception {} {}", why, ex, ex);
Review comment:
I think you have an extra ex - or you need another {}.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #1879: Include stack trace in log for DfsLogger.fail()
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #1879:
URL: https://github.com/apache/accumulo/pull/1879
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org