You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "maedhroz (via GitHub)" <gi...@apache.org> on 2023/06/01 19:52:37 UTC
[GitHub] [cassandra] maedhroz opened a new pull request, #2381: CEP-7 SAI rebase on trunk fad1f7457032544ab6a7b40c5d38ecb8b25899bb
maedhroz opened a new pull request, #2381:
URL: https://github.com/apache/cassandra/pull/2381
@mike-tr-adamson @blambov Here are my notes from the rebase:
- Should `TrieNode.ordinal` initialize to `-1` or `0`?
- It looks like in `DataOutputPlus`, SAI added an actual implementation for `padToPageBoundary()`. Is that going to be problematic?
- `SequentialWriter` now uses the `bytesLeftInPage()` implementation in `PageAware` rather than a custom one.
- The tests I've spot-checked have looked pretty good, but `SortedTermsTest#testFileValidation()` is failing to verify the checksum on the `PRIMARY_KEY_TRIE`. I've tried to revert `DataOutputPlus` and `SequentialWriter` to their current `cep-7-sai` versions, but that doesn't seem to make a difference. Not sure what's going on there...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] maedhroz commented on pull request #2381: CEP-7 SAI rebase on trunk fad1f7457032544ab6a7b40c5d38ecb8b25899bb
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on PR #2381:
URL: https://github.com/apache/cassandra/pull/2381#issuecomment-1572682988
CircleCI: https://app.circleci.com/pipelines/github/maedhroz/cassandra?branch=cep-7-sai-5-30-rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] maedhroz closed pull request #2381: CEP-7 SAI rebase on trunk 6cea0cd448d11dc633237ceb1f73f36c2eafb368
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz closed pull request #2381: CEP-7 SAI rebase on trunk 6cea0cd448d11dc633237ceb1f73f36c2eafb368
URL: https://github.com/apache/cassandra/pull/2381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org