You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Mihai Chira <mi...@gmail.com> on 2015/12/03 15:01:38 UTC
Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854
FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854
haven't changed anything about findItem.
About to commit and push a fix for this in the next hour. (It took me
so long because my HDD had bad sectors which caused lots of pain in
the last few days.)
On 24 November 2015 at 18:03, Alex Harui <ah...@adobe.com> wrote:
>
>
> On 11/24/15, 8:41 AM, "Mihai Chira" <mi...@gmail.com> wrote:
>
>>Yes, but the earliest I can do that is on Monday. I hope that still works
>>regarding the release. (And I hope I'll manage to solve it, but we'll
>>see.)
>>On 24 Nov 2015 08:19, "Alex Harui" <ah...@adobe.com> wrote:
>
> I don't know of any plans to cut an RC this week, so I think Monday should
> be ok.
>
> Thanks,
> Alex
>
Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854
FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854
haven't changed anything about findItem.
Posted by Mihai Chira <mi...@gmail.com>.
Yay! Thank you.
On 10 December 2015 at 17:52, Alex Harui <ah...@adobe.com> wrote:
>
>
> On 12/10/15, 1:00 AM, "Mihai Chira" <mi...@gmail.com> wrote:
>
>>Finding "FAIL: .*Sort" in the old reports highlights about 21 lines,
>>and in the new ones none. So I guess the sorting bugs have been fixed?
>>Or should we wait until we restart mustella for a confirmation?
>
> I think you have resolved all of the sorting problems. Congratulations!
>
> -Alex
>
Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854
FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854
haven't changed anything about findItem.
Posted by Alex Harui <ah...@adobe.com>.
On 12/10/15, 1:00 AM, "Mihai Chira" <mi...@gmail.com> wrote:
>Finding "FAIL: .*Sort" in the old reports highlights about 21 lines,
>and in the new ones none. So I guess the sorting bugs have been fixed?
>Or should we wait until we restart mustella for a confirmation?
I think you have resolved all of the sorting problems. Congratulations!
-Alex
Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854
FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854
haven't changed anything about findItem.
Posted by Mihai Chira <mi...@gmail.com>.
Finding "FAIL: .*Sort" in the old reports highlights about 21 lines,
and in the new ones none. So I guess the sorting bugs have been fixed?
Or should we wait until we restart mustella for a confirmation?
On 8 December 2015 at 17:19, Alex Harui <ah...@adobe.com> wrote:
> Thanks for sticking with it. I have my fingers crossed.
>
> -Alex
>
> On 12/8/15, 7:58 AM, "Mihai Chira" <mi...@gmail.com> wrote:
>
>>Just pushed another commit. Locally all the mustella tests in the
>>spark/Collections/Sort/Other are now passing, fingers crossed that all
>>the other sort-related ones will also pass.
>>The lesson: moving from inheritance to composition can be super
>>complicated! Events, the new class member using "this" instead of the
>>parent, framework classes calling functions via object["initialized"]
>>instead of an interface, etc. Still worth it, though, to remove code
>>duplication (in this case the mx versions of Sort and SortField were
>>mostly - and imperfectly - copy-pasted in their spark counterparts.
>>This meant that a change to one had to be reflected in the other,
>>which usually didn't happen. It also meant that tests would have
>>needed duplication as well, etc).
>>
>>On 3 December 2015 at 15:51, Mihai Chira <mi...@gmail.com> wrote:
>>> In the end it's an improvement, but in the end 5 test cases are still
>>> failing. Right now I'm travelling, and won't be able to take another
>>> look until Saturday. Does someone else want to help out?
>>>
>>> On 3 December 2015 at 15:18, Alex Harui <ah...@adobe.com> wrote:
>>>> Excellent! Thanks, -Alex
>>>>
>>>> On 12/3/15, 6:01 AM, "Mihai Chira" <mi...@gmail.com> wrote:
>>>>
>>>>>About to commit and push a fix for this in the next hour. (It took me
>>>>>so long because my HDD had bad sectors which caused lots of pain in
>>>>>the last few days.)
>>>>>
>>>>>On 24 November 2015 at 18:03, Alex Harui <ah...@adobe.com> wrote:
>>>>>>
>>>>>>
>>>>>> On 11/24/15, 8:41 AM, "Mihai Chira" <mi...@gmail.com> wrote:
>>>>>>
>>>>>>>Yes, but the earliest I can do that is on Monday. I hope that still
>>>>>>>works
>>>>>>>regarding the release. (And I hope I'll manage to solve it, but we'll
>>>>>>>see.)
>>>>>>>On 24 Nov 2015 08:19, "Alex Harui" <ah...@adobe.com> wrote:
>>>>>>
>>>>>> I don't know of any plans to cut an RC this week, so I think Monday
>>>>>>should
>>>>>> be ok.
>>>>>>
>>>>>> Thanks,
>>>>>> Alex
>>>>>>
>>>>
>
Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854
FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854
haven't changed anything about findItem.
Posted by Alex Harui <ah...@adobe.com>.
Thanks for sticking with it. I have my fingers crossed.
-Alex
On 12/8/15, 7:58 AM, "Mihai Chira" <mi...@gmail.com> wrote:
>Just pushed another commit. Locally all the mustella tests in the
>spark/Collections/Sort/Other are now passing, fingers crossed that all
>the other sort-related ones will also pass.
>The lesson: moving from inheritance to composition can be super
>complicated! Events, the new class member using "this" instead of the
>parent, framework classes calling functions via object["initialized"]
>instead of an interface, etc. Still worth it, though, to remove code
>duplication (in this case the mx versions of Sort and SortField were
>mostly - and imperfectly - copy-pasted in their spark counterparts.
>This meant that a change to one had to be reflected in the other,
>which usually didn't happen. It also meant that tests would have
>needed duplication as well, etc).
>
>On 3 December 2015 at 15:51, Mihai Chira <mi...@gmail.com> wrote:
>> In the end it's an improvement, but in the end 5 test cases are still
>> failing. Right now I'm travelling, and won't be able to take another
>> look until Saturday. Does someone else want to help out?
>>
>> On 3 December 2015 at 15:18, Alex Harui <ah...@adobe.com> wrote:
>>> Excellent! Thanks, -Alex
>>>
>>> On 12/3/15, 6:01 AM, "Mihai Chira" <mi...@gmail.com> wrote:
>>>
>>>>About to commit and push a fix for this in the next hour. (It took me
>>>>so long because my HDD had bad sectors which caused lots of pain in
>>>>the last few days.)
>>>>
>>>>On 24 November 2015 at 18:03, Alex Harui <ah...@adobe.com> wrote:
>>>>>
>>>>>
>>>>> On 11/24/15, 8:41 AM, "Mihai Chira" <mi...@gmail.com> wrote:
>>>>>
>>>>>>Yes, but the earliest I can do that is on Monday. I hope that still
>>>>>>works
>>>>>>regarding the release. (And I hope I'll manage to solve it, but we'll
>>>>>>see.)
>>>>>>On 24 Nov 2015 08:19, "Alex Harui" <ah...@adobe.com> wrote:
>>>>>
>>>>> I don't know of any plans to cut an RC this week, so I think Monday
>>>>>should
>>>>> be ok.
>>>>>
>>>>> Thanks,
>>>>> Alex
>>>>>
>>>
Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854
FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854
haven't changed anything about findItem.
Posted by Mihai Chira <mi...@gmail.com>.
Just pushed another commit. Locally all the mustella tests in the
spark/Collections/Sort/Other are now passing, fingers crossed that all
the other sort-related ones will also pass.
The lesson: moving from inheritance to composition can be super
complicated! Events, the new class member using "this" instead of the
parent, framework classes calling functions via object["initialized"]
instead of an interface, etc. Still worth it, though, to remove code
duplication (in this case the mx versions of Sort and SortField were
mostly - and imperfectly - copy-pasted in their spark counterparts.
This meant that a change to one had to be reflected in the other,
which usually didn't happen. It also meant that tests would have
needed duplication as well, etc).
On 3 December 2015 at 15:51, Mihai Chira <mi...@gmail.com> wrote:
> In the end it's an improvement, but in the end 5 test cases are still
> failing. Right now I'm travelling, and won't be able to take another
> look until Saturday. Does someone else want to help out?
>
> On 3 December 2015 at 15:18, Alex Harui <ah...@adobe.com> wrote:
>> Excellent! Thanks, -Alex
>>
>> On 12/3/15, 6:01 AM, "Mihai Chira" <mi...@gmail.com> wrote:
>>
>>>About to commit and push a fix for this in the next hour. (It took me
>>>so long because my HDD had bad sectors which caused lots of pain in
>>>the last few days.)
>>>
>>>On 24 November 2015 at 18:03, Alex Harui <ah...@adobe.com> wrote:
>>>>
>>>>
>>>> On 11/24/15, 8:41 AM, "Mihai Chira" <mi...@gmail.com> wrote:
>>>>
>>>>>Yes, but the earliest I can do that is on Monday. I hope that still
>>>>>works
>>>>>regarding the release. (And I hope I'll manage to solve it, but we'll
>>>>>see.)
>>>>>On 24 Nov 2015 08:19, "Alex Harui" <ah...@adobe.com> wrote:
>>>>
>>>> I don't know of any plans to cut an RC this week, so I think Monday
>>>>should
>>>> be ok.
>>>>
>>>> Thanks,
>>>> Alex
>>>>
>>
Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854
FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854
haven't changed anything about findItem.
Posted by Mihai Chira <mi...@gmail.com>.
In the end it's an improvement, but in the end 5 test cases are still
failing. Right now I'm travelling, and won't be able to take another
look until Saturday. Does someone else want to help out?
On 3 December 2015 at 15:18, Alex Harui <ah...@adobe.com> wrote:
> Excellent! Thanks, -Alex
>
> On 12/3/15, 6:01 AM, "Mihai Chira" <mi...@gmail.com> wrote:
>
>>About to commit and push a fix for this in the next hour. (It took me
>>so long because my HDD had bad sectors which caused lots of pain in
>>the last few days.)
>>
>>On 24 November 2015 at 18:03, Alex Harui <ah...@adobe.com> wrote:
>>>
>>>
>>> On 11/24/15, 8:41 AM, "Mihai Chira" <mi...@gmail.com> wrote:
>>>
>>>>Yes, but the earliest I can do that is on Monday. I hope that still
>>>>works
>>>>regarding the release. (And I hope I'll manage to solve it, but we'll
>>>>see.)
>>>>On 24 Nov 2015 08:19, "Alex Harui" <ah...@adobe.com> wrote:
>>>
>>> I don't know of any plans to cut an RC this week, so I think Monday
>>>should
>>> be ok.
>>>
>>> Thanks,
>>> Alex
>>>
>
Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854
FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854
haven't changed anything about findItem.
Posted by Alex Harui <ah...@adobe.com>.
Excellent! Thanks, -Alex
On 12/3/15, 6:01 AM, "Mihai Chira" <mi...@gmail.com> wrote:
>About to commit and push a fix for this in the next hour. (It took me
>so long because my HDD had bad sectors which caused lots of pain in
>the last few days.)
>
>On 24 November 2015 at 18:03, Alex Harui <ah...@adobe.com> wrote:
>>
>>
>> On 11/24/15, 8:41 AM, "Mihai Chira" <mi...@gmail.com> wrote:
>>
>>>Yes, but the earliest I can do that is on Monday. I hope that still
>>>works
>>>regarding the release. (And I hope I'll manage to solve it, but we'll
>>>see.)
>>>On 24 Nov 2015 08:19, "Alex Harui" <ah...@adobe.com> wrote:
>>
>> I don't know of any plans to cut an RC this week, so I think Monday
>>should
>> be ok.
>>
>> Thanks,
>> Alex
>>