You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/08/10 18:43:30 UTC
[GitHub] [pinot] ravishankar15 opened a new pull request, #9193: Adding kafka offset support for period and timestamp
ravishankar15 opened a new pull request, #9193:
URL: https://github.com/apache/pinot/pull/9193
Fix #7250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9193: Adding kafka offset support for period and timestamp
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on code in PR #9193:
URL: https://github.com/apache/pinot/pull/9193#discussion_r947313065
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/OffsetCriteria.java:
##########
@@ -172,17 +196,21 @@ public OffsetCriteria withOffsetString(String offsetString) {
_offsetCriteria.setOffsetType(OffsetType.SMALLEST);
} else if (offsetString.equalsIgnoreCase(OffsetType.LARGEST.toString())) {
_offsetCriteria.setOffsetType(OffsetType.LARGEST);
- } else {
+ } else if (TimeUtils.isPeriodValid(offsetString)) {
try {
- Long periodToMillis = TimeUtils.convertPeriodToMillis(offsetString);
+ long periodToMillis = TimeUtils.convertPeriodToMillis(offsetString);
if (periodToMillis >= 0) {
_offsetCriteria.setOffsetType(OffsetType.PERIOD);
} else {
_offsetCriteria.setOffsetType(OffsetType.CUSTOM);
}
- } catch (Exception e) {
- _offsetCriteria.setOffsetType(OffsetType.CUSTOM);
+ } catch (Exception ignore) {
Review Comment:
Since we already check if the period is valid, we should just remove the try-catch
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaStreamMetadataProvider.java:
##########
@@ -63,6 +70,28 @@ public StreamPartitionMsgOffset fetchStreamPartitionOffset(OffsetCriteria offset
offset =
_consumer.beginningOffsets(Collections.singletonList(_topicPartition), Duration.ofMillis(timeoutMillis))
.get(_topicPartition);
+ } else if (offsetCriteria.isPeriod()) {
+ OffsetAndTimestamp offsetAndTimestamp = _consumer.offsetsForTimes(Collections.singletonMap(_topicPartition,
+ Clock.systemUTC().millis() - TimeUtils.convertPeriodToMillis(offsetCriteria.getOffsetString())))
+ .get(_topicPartition);
+ if (offsetAndTimestamp == null) {
+ LOGGER.warn("initial offset type is period and its value evaluates to null hence proceeding with endOffset");
Review Comment:
Suggest also logging the topic partition and offset string to provide more info for debugging
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaStreamMetadataProvider.java:
##########
@@ -63,6 +70,28 @@ public StreamPartitionMsgOffset fetchStreamPartitionOffset(OffsetCriteria offset
offset =
_consumer.beginningOffsets(Collections.singletonList(_topicPartition), Duration.ofMillis(timeoutMillis))
.get(_topicPartition);
+ } else if (offsetCriteria.isPeriod()) {
+ OffsetAndTimestamp offsetAndTimestamp = _consumer.offsetsForTimes(Collections.singletonMap(_topicPartition,
+ Clock.systemUTC().millis() - TimeUtils.convertPeriodToMillis(offsetCriteria.getOffsetString())))
+ .get(_topicPartition);
+ if (offsetAndTimestamp == null) {
+ LOGGER.warn("initial offset type is period and its value evaluates to null hence proceeding with endOffset");
+ offset = _consumer.endOffsets(Collections.singletonList(_topicPartition), Duration.ofMillis(timeoutMillis))
+ .get(_topicPartition);
+ } else {
+ offset = offsetAndTimestamp.offset();
+ }
+ } else if (offsetCriteria.isTimestamp()) {
+ OffsetAndTimestamp offsetAndTimestamp = _consumer.offsetsForTimes(Collections.singletonMap(_topicPartition,
+ TimeUtils.convertTimestampToMillis(offsetCriteria.getOffsetString()))).get(_topicPartition);
+ if (offsetAndTimestamp == null) {
+ LOGGER.warn("initial offset type is timestamp and its value evaluates "
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9193: Adding kafka offset support for period and timestamp
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on code in PR #9193:
URL: https://github.com/apache/pinot/pull/9193#discussion_r946176802
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/TimeUtils.java:
##########
@@ -167,6 +169,44 @@ public static Long convertPeriodToMillis(String timeStr) {
return millis;
}
+ /**
+ * Returns the millisecond of the period since the @since millisecond
+ * For ex, getMillisFromPeriod("2d",
+ * Clock.fixed(java.time.Instant.ofEpochMilli(1660054290324L), ZoneId.of("UTC"))) -> 1659881490324
+ * The milliseconds of 2d is 172800000 hence the millisecond of 2d since 1660054290324 is
+ * 1660054290324 - 172800000 = 1659881490324
+ *
+ * @param timeStr string representing the duration
+ * @param since Clock representing the time from which the period needs to be computed
+ * @return the corresponding time converted to milliseconds
+ * @throws IllegalArgumentException if the string does not conform to the expected format
+ */
+ public static long getMillisFromPeriod(String timeStr, Clock since) {
+ long periodToMillis = convertPeriodToMillis(timeStr);
+ return since.millis() - periodToMillis;
Review Comment:
Seems we want to go back a certain period from the passed in time. IMO this method is a little bit confusing, so suggest removing it and make the caller use `convertPeriodToMillis()` instead
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/OffsetCriteria.java:
##########
@@ -148,6 +159,18 @@ public OffsetCriteria withOffsetAsPeriod(String periodString) {
return _offsetCriteria;
}
+ /**
+ * Builds an {@link OffsetCriteria} with {@link OffsetType} TIMESTAMP
+ * @param timestamp
+ * @return
+ */
+ public OffsetCriteria withOffsetAsTimestamp(String timestamp) {
+ Preconditions.checkNotNull(timestamp, "Must provide period string eg. 10d, 4h30m etc");
Review Comment:
Modify the exception message
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/TimeUtils.java:
##########
@@ -189,6 +229,19 @@ public static String convertMillisToPeriod(Long millis) {
public static boolean isPeriodValid(String timeStr) {
try {
PERIOD_FORMATTER.parsePeriod(timeStr);
+ long periodToMillis = convertPeriodToMillis(timeStr);
+ return periodToMillis >= 0;
Review Comment:
Suggest not adding this extra check. Negative period should also be valid
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/TimeUtils.java:
##########
@@ -167,6 +169,44 @@ public static Long convertPeriodToMillis(String timeStr) {
return millis;
}
+ /**
+ * Returns the millisecond of the period since the @since millisecond
+ * For ex, getMillisFromPeriod("2d",
+ * Clock.fixed(java.time.Instant.ofEpochMilli(1660054290324L), ZoneId.of("UTC"))) -> 1659881490324
+ * The milliseconds of 2d is 172800000 hence the millisecond of 2d since 1660054290324 is
+ * 1660054290324 - 172800000 = 1659881490324
+ *
+ * @param timeStr string representing the duration
+ * @param since Clock representing the time from which the period needs to be computed
+ * @return the corresponding time converted to milliseconds
+ * @throws IllegalArgumentException if the string does not conform to the expected format
+ */
+ public static long getMillisFromPeriod(String timeStr, Clock since) {
+ long periodToMillis = convertPeriodToMillis(timeStr);
+ return since.millis() - periodToMillis;
+ }
+
+ /**
+ * Converts a string representing the timestamp to corresponding milliseconds.
+ *
+ * @param timeStr string representing the timestamp in ISO 8601 format
+ * @return the corresponding time converted to milliseconds
+ * @throws IllegalArgumentException if the string does not conform to the expected format
+ */
+ public static Long convertDateTimeToMillis(String timeStr) {
Review Comment:
```suggestion
public static Long convertTimestampToMillis(String timeStr) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] npawar commented on pull request #9193: Adding kafka offset support for period and timestamp
Posted by GitBox <gi...@apache.org>.
npawar commented on PR #9193:
URL: https://github.com/apache/pinot/pull/9193#issuecomment-1229280313
> Fix #7250
@ravishankar15 would you please update the docs? Right now it reads incorrect: https://docs.pinot.apache.org/basics/data-import/pinot-stream-ingestion/import-from-apache-kafka#creating-a-table-configuration
Here as well: https://docs.pinot.apache.org/configuration-reference/table#indexing-config
Thanks in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #9193: Adding kafka offset support for period and timestamp
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged PR #9193:
URL: https://github.com/apache/pinot/pull/9193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ravishankar15 commented on pull request #9193: Adding kafka offset support for period and timestamp
Posted by GitBox <gi...@apache.org>.
ravishankar15 commented on PR #9193:
URL: https://github.com/apache/pinot/pull/9193#issuecomment-1229455802
> > Fix #7250
>
> @ravishankar15 would you please update the docs? Right now it reads incorrect: https://docs.pinot.apache.org/basics/data-import/pinot-stream-ingestion/import-from-apache-kafka#creating-a-table-configuration
>
> Here as well: https://docs.pinot.apache.org/configuration-reference/table#indexing-config
>
> Thanks in advance!
@npawar I think the master changes in the doc is not reflecting in the official documentation I have made the doc changes to the master Ref: https://github.com/pinot-contrib/pinot-docs/pull/115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #9193: Adding kafka offset support for period and timestamp
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #9193:
URL: https://github.com/apache/pinot/pull/9193#issuecomment-1211541108
# [Codecov](https://codecov.io/gh/apache/pinot/pull/9193?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9193](https://codecov.io/gh/apache/pinot/pull/9193?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b29399) into [master](https://codecov.io/gh/apache/pinot/commit/6ed17d298a7d0fbeaab7a59b6d998e4bfeec6ba7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6ed17d2) will **decrease** coverage by `54.76%`.
> The diff coverage is `22.50%`.
```diff
@@ Coverage Diff @@
## master #9193 +/- ##
=============================================
- Coverage 70.04% 15.27% -54.77%
+ Complexity 5003 170 -4833
=============================================
Files 1852 1802 -50
Lines 98760 96680 -2080
Branches 15021 14789 -232
=============================================
- Hits 69175 14767 -54408
- Misses 24709 80855 +56146
+ Partials 4876 1058 -3818
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `15.27% <22.50%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/9193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/pinot/spi/stream/OffsetCriteria.java](https://codecov.io/gh/apache/pinot/pull/9193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvc3RyZWFtL09mZnNldENyaXRlcmlhLmphdmE=) | `0.00% <0.00%> (-90.00%)` | :arrow_down: |
| [...ain/java/org/apache/pinot/spi/utils/TimeUtils.java](https://codecov.io/gh/apache/pinot/pull/9193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvVGltZVV0aWxzLmphdmE=) | `0.00% <0.00%> (-97.44%)` | :arrow_down: |
| [...in/stream/kafka20/KafkaStreamMetadataProvider.java](https://codecov.io/gh/apache/pinot/pull/9193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcGx1Z2lucy9waW5vdC1zdHJlYW0taW5nZXN0aW9uL3Bpbm90LWthZmthLTIuMC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcGx1Z2luL3N0cmVhbS9rYWZrYTIwL0thZmthU3RyZWFtTWV0YWRhdGFQcm92aWRlci5qYXZh) | `64.86% <60.00%> (-6.57%)` | :arrow_down: |
| [...src/main/java/org/apache/pinot/sql/FilterKind.java](https://codecov.io/gh/apache/pinot/pull/9193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvRmlsdGVyS2luZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ain/java/org/apache/pinot/core/data/table/Key.java](https://codecov.io/gh/apache/pinot/pull/9193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL0tleS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...in/java/org/apache/pinot/spi/utils/BytesUtils.java](https://codecov.io/gh/apache/pinot/pull/9193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQnl0ZXNVdGlscy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/spi/utils/BooleanUtils.java](https://codecov.io/gh/apache/pinot/pull/9193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQm9vbGVhblV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/core/data/table/Record.java](https://codecov.io/gh/apache/pinot/pull/9193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/core/util/GroupByUtils.java](https://codecov.io/gh/apache/pinot/pull/9193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL0dyb3VwQnlVdGlscy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...java/org/apache/pinot/spi/trace/BaseRecording.java](https://codecov.io/gh/apache/pinot/pull/9193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdHJhY2UvQmFzZVJlY29yZGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1402 more](https://codecov.io/gh/apache/pinot/pull/9193/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] npawar commented on a diff in pull request #9193: Adding kafka offset support for period and timestamp
Posted by GitBox <gi...@apache.org>.
npawar commented on code in PR #9193:
URL: https://github.com/apache/pinot/pull/9193#discussion_r947032176
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaStreamMetadataProvider.java:
##########
@@ -63,6 +66,25 @@ public StreamPartitionMsgOffset fetchStreamPartitionOffset(OffsetCriteria offset
offset =
_consumer.beginningOffsets(Collections.singletonList(_topicPartition), Duration.ofMillis(timeoutMillis))
.get(_topicPartition);
+ } else if (offsetCriteria.isPeriod()) {
+ OffsetAndTimestamp offsetAndTimestamp = _consumer.offsetsForTimes(Collections.singletonMap(_topicPartition,
+ Clock.systemUTC().millis() - TimeUtils.convertPeriodToMillis(offsetCriteria.getOffsetString())))
+ .get(_topicPartition);
+ if (offsetAndTimestamp == null) {
+ offset = _consumer.endOffsets(Collections.singletonList(_topicPartition), Duration.ofMillis(timeoutMillis))
Review Comment:
nit: in both cases, log a warn if offsetAndTimestamp == null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on pull request #9193: Adding kafka offset support for period and timestamp
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on PR #9193:
URL: https://github.com/apache/pinot/pull/9193#issuecomment-1218345654
@ravishankar15 Thanks for contributing the feature! Can you help also update the Pinot documentation to include the new config options? The documentation is backed by this repo: https://github.com/pinot-contrib/pinot-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org