You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/06 05:45:50 UTC

[GitHub] [incubator-doris] qzsee opened a new pull request, #9401: [Enhancement] improve the performance of multi distinct

qzsee opened a new pull request, #9401:
URL: https://github.com/apache/incubator-doris/pull/9401

   # Proposed changes
   
   Issue Number: close #9400 
   
   I replaced the unordered set with phmap flat hash set
   
   ```sql
   SELECT COUNT(DISTINCT k1) , COUNT(DISTINCT k2) FROM tbl WHERE dt >= 20211001 AND dt <= 20220406 
   ```
   before:  32.23 sec
   after:  6.34 sec
   
   
   ## Problem Summary:
   
   Describe the overview of changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9401: [Enhancement] improve the performance of multi distinct

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9401:
URL: https://github.com/apache/incubator-doris/pull/9401#issuecomment-1119325505

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] qzsee commented on pull request #9401: [Enhancement] improve the performance of multi distinct

Posted by GitBox <gi...@apache.org>.
qzsee commented on PR #9401:
URL: https://github.com/apache/incubator-doris/pull/9401#issuecomment-1119283705

   @liutang123 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9401: [Enhancement] improve the performance of multi distinct

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9401:
URL: https://github.com/apache/incubator-doris/pull/9401#issuecomment-1119325474

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] qzsee commented on pull request #9401: [Enhancement] improve the performance of multi distinct

Posted by GitBox <gi...@apache.org>.
qzsee commented on PR #9401:
URL: https://github.com/apache/incubator-doris/pull/9401#issuecomment-1119345086

   > @qzsee Have you test vectorized engine? I find you modified the non-vectorized engine.
   
   I don't test in vectorized engine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] yiguolei commented on pull request #9401: [Enhancement] improve the performance of multi distinct

Posted by GitBox <gi...@apache.org>.
yiguolei commented on PR #9401:
URL: https://github.com/apache/incubator-doris/pull/9401#issuecomment-1119328684

   @qzsee Have you test vectorized engine? I find you modified the non-vectorized engine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] yiguolei merged pull request #9401: [Enhancement] improve the performance of multi distinct

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9401:
URL: https://github.com/apache/incubator-doris/pull/9401


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org