[GitHub] [activemq-nms-openwire] michaelandrepearce edited a comment on issue #9: [AMQNET-565] - .net standard conversion, project reorganization

[GitBox <gi...@apache.org>]

michaelandrepearce edited a comment on issue #9:
URL: https://github.com/apache/activemq-nms-openwire/pull/9#issuecomment-616250391


   @lrushl if your picking this up, first of all thanks, im sure @killnine will appreciate.
   
   - Unit tests
   
   1. DTC tests should be ignored when platform is CORE, but should run and pass when on framework. When doing a full batch build, both should be built, and both CORE and Framework tests should be run, we should ensure the ignore is only when on CORE. e.g. tests should be multi target    <TargetFrameworks>net462;netcoreapp2.2</TargetFrameworks>
   
   
   2. The 3 other failures should be fixed before this PR can merge, if you believe they're pre existing i'm happy for it to be a separate PR (and Jira) which gets merged first, or part of this PR.
   
   
   - Protocol upgrade is out of scope, that should have its own JIRA and own PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org