You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "cmarteepants (via GitHub)" <gi...@apache.org> on 2025/09/19 01:25:10 UTC
[PR] (docs) update core concepts dags screenshots [airflow]
cmarteepants opened a new pull request, #55865:
URL: https://github.com/apache/airflow/pull/55865
This updates screenshots in core concepts – dags because of UI refresh
Refs: #55521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] (docs) update core concepts dags screenshots [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil merged PR #55865:
URL: https://github.com/apache/airflow/pull/55865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] (docs) update core concepts dags screenshots [airflow]
Posted by "cmarteepants (via GitHub)" <gi...@apache.org>.
cmarteepants commented on code in PR #55865:
URL: https://github.com/apache/airflow/pull/55865#discussion_r2363162388
##########
airflow-core/docs/img/ui-light/branch_with_trigger.png:
##########
Review Comment:
Yes it was. I was trying to show the difference in the code. I can add a square around it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] (docs) update core concepts dags screenshots [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #55865:
URL: https://github.com/apache/airflow/pull/55865#discussion_r2361544010
##########
airflow-core/docs/img/ui-light/branch_with_trigger.png:
##########
Review Comment:
@cmarteepants Is it intentional to have the entire window and not just the branch one like earlier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] (docs) update core concepts dags screenshots [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #55865:
URL: https://github.com/apache/airflow/pull/55865#discussion_r2361544473
##########
airflow-core/docs/img/ui-dark/branch_without_trigger.png:
##########
Review Comment:
Is it intentional to have the Code view and large window, that just the graph?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] (docs) update core concepts dags screenshots [airflow]
Posted by "cmarteepants (via GitHub)" <gi...@apache.org>.
cmarteepants commented on code in PR #55865:
URL: https://github.com/apache/airflow/pull/55865#discussion_r2363202975
##########
airflow-core/docs/img/ui-light/branch_with_trigger.png:
##########
Review Comment:
I was being lazy by just trying to highlight it. I updated the screenshots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] (docs) update core concepts dags screenshots [airflow]
Posted by "cmarteepants (via GitHub)" <gi...@apache.org>.
cmarteepants commented on code in PR #55865:
URL: https://github.com/apache/airflow/pull/55865#discussion_r2363162388
##########
airflow-core/docs/img/ui-light/branch_with_trigger.png:
##########
Review Comment:
I can crop the image if we think that's better, but was just trying to be consistent with the zoom like you mentioned in the issue. Let me know!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] (docs) update core concepts dags screenshots [airflow]
Posted by "cmarteepants (via GitHub)" <gi...@apache.org>.
cmarteepants commented on code in PR #55865:
URL: https://github.com/apache/airflow/pull/55865#discussion_r2363162388
##########
airflow-core/docs/img/ui-light/branch_with_trigger.png:
##########
Review Comment:
Yes it was. I was trying to show the difference in the code. I can add a square around it to make that easier.
##########
airflow-core/docs/img/ui-dark/branch_without_trigger.png:
##########
Review Comment:
Same as above. Was trying to draw attention to the difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] (docs) update core concepts dags screenshots [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #55865:
URL: https://github.com/apache/airflow/pull/55865#discussion_r2363194590
##########
airflow-core/docs/img/ui-light/branch_with_trigger.png:
##########
Review Comment:
I am fine with either :) You'd be the best judge haha. I just wanted to ensure if it is intentional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org