You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/08/24 09:46:07 UTC

[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request, #3299: [SCB-2673]Fix NPE problem when auto discovery enabled

liubao68 opened a new pull request, #3299:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3299

   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #3299: [SCB-2673]Fix NPE problem when auto discovery enabled

Posted by GitBox <gi...@apache.org>.
liubao68 merged PR #3299:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3299


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3299: [SCB-2673]Fix NPE problem when auto discovery enabled

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3299:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3299#issuecomment-1228192804

   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3299?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3299](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3299?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a11849) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/667733118c10b34d597e0ebca01b7a885b797239?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6677331) will **increase** coverage by `0.00%`.
   > The diff coverage is `67.69%`.
   
   > :exclamation: Current head 8a11849 differs from pull request most recent head 9e26f48. Consider uploading reports for the commit 9e26f48 to get more accurate results
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #3299   +/-   ##
   =========================================
     Coverage     77.41%   77.41%           
   - Complexity     1449     1452    +3     
   =========================================
     Files          1649     1650    +1     
     Lines         43721    43740   +19     
     Branches       3674     3676    +2     
   =========================================
   + Hits          33847    33862   +15     
   - Misses         8347     8350    +3     
   - Partials       1527     1528    +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...nfig/center/client/ConfigCenterAddressManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9jb25maWctY2VudGVyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2NlbnRlci9jbGllbnQvQ29uZmlnQ2VudGVyQWRkcmVzc01hbmFnZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...ecomb/config/center/client/ConfigCenterClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9jb25maWctY2VudGVyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2NlbnRlci9jbGllbnQvQ29uZmlnQ2VudGVyQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ice/center/client/ServiceCenterAddressManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9zZXJ2aWNlLWNlbnRlci1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3NlcnZpY2UvY2VudGVyL2NsaWVudC9TZXJ2aWNlQ2VudGVyQWRkcmVzc01hbmFnZXIuamF2YQ==) | `71.42% <ø> (ø)` | |
   | [...omb/service/center/client/ServiceCenterClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9zZXJ2aWNlLWNlbnRlci1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3NlcnZpY2UvY2VudGVyL2NsaWVudC9TZXJ2aWNlQ2VudGVyQ2xpZW50LmphdmE=) | `24.30% <ø> (ø)` | |
   | [...comb/service/center/client/ServiceCenterWatch.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9zZXJ2aWNlLWNlbnRlci1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3NlcnZpY2UvY2VudGVyL2NsaWVudC9TZXJ2aWNlQ2VudGVyV2F0Y2guamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...mb/config/ConfigCenterConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvQ29uZmlnQ2VudGVyQ29uZmlndXJhdGlvblNvdXJjZUltcGwuamF2YQ==) | `10.63% <0.00%> (+1.06%)` | :arrow_up: |
   | [...omb/serviceregistry/auth/RBACBootStrapService.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2F1dGgvUkJBQ0Jvb3RTdHJhcFNlcnZpY2UuamF2YQ==) | `8.53% <0.00%> (ø)` | |
   | [...omb/http/client/common/AbstractAddressManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9odHRwLWNsaWVudC1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2h0dHAvY2xpZW50L2NvbW1vbi9BYnN0cmFjdEFkZHJlc3NNYW5hZ2VyLmphdmE=) | `75.55% <69.56%> (-5.40%)` | :arrow_down: |
   | [...comb/demo/springmvc/client/TestControllerImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLXNwcmluZ212Yy9zcHJpbmdtdmMtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9kZW1vL3NwcmluZ212Yy9jbGllbnQvVGVzdENvbnRyb2xsZXJJbXBsLmphdmE=) | `80.00% <80.00%> (ø)` | |
   | [.../service/center/client/ServiceCenterRawClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9zZXJ2aWNlLWNlbnRlci1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3NlcnZpY2UvY2VudGVyL2NsaWVudC9TZXJ2aWNlQ2VudGVyUmF3Q2xpZW50LmphdmE=) | `65.00% <100.00%> (ø)` | |
   | ... and [7 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3299/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org