Re: svn commit: r17275 - in trunk/subversion/tests/clients/cmdline: svntest

[Philip Martin <ph...@codematters.co.uk>]

djames@tigris.org writes:

> Author: djames
> Date: Wed Nov  9 13:28:13 2005
> New Revision: 17275
>
> Modified:
>    trunk/subversion/tests/clients/cmdline/commit_tests.py
>    trunk/subversion/tests/clients/cmdline/svntest/main.py
>
> Log:
> Issue #443: Post-commit hook script (error) output lost.
> Fix portability issues in commit_tests 34.
>
> * subversion/tests/clients/cmdline/commit_tests.py
>   (post_commit_hook_test): Use the create_python_hook_script function
>   for better portability.
>
> * subversion/tests/clients/cmdline/svntest/main.py
>   (create_python_hook_script): New function. Creates a portable Python based
>   hook script.

This seems to be taking a completely different approach to the
existing code, namely the enable_revprop_changes function in
action.py.  It would be more consistent to have something like a
disable_commit function in actions.py.  Why is this new function in
main.py while enable_revprop_changes is in action.py?

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r17275 - in trunk/subversion/tests/clients/cmdline: svntest

[David James <ja...@gmail.com>]

On 11/9/05, Philip Martin <ph...@codematters.co.uk> wrote:
> djames@tigris.org writes:
>
> > Author: djames
> > Date: Wed Nov  9 13:28:13 2005
> > New Revision: 17275
> >
> > Modified:
> >    trunk/subversion/tests/clients/cmdline/commit_tests.py
> >    trunk/subversion/tests/clients/cmdline/svntest/main.py
> >
> > Log:
> > Issue #443: Post-commit hook script (error) output lost.
> > Fix portability issues in commit_tests 34.
> >
> > * subversion/tests/clients/cmdline/commit_tests.py
> >   (post_commit_hook_test): Use the create_python_hook_script function
> >   for better portability.
> >
> > * subversion/tests/clients/cmdline/svntest/main.py
> >   (create_python_hook_script): New function. Creates a portable Python based
> >   hook script.
>
> This seems to be taking a completely different approach to the
> existing code, namely the enable_revprop_changes function in
> action.py.  It would be more consistent to have something like a
> disable_commit function in actions.py.  Why is this new function in
> main.py while enable_revprop_changes is in action.py?
Fixed in r17285. I've created a "disable_commits" function in
actions.py to handle this logic.

Thanks for your review, Philip!

David



--
David James -- http://www.cs.toronto.edu/~james