You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "reshke (via GitHub)" <gi...@apache.org> on 2024/11/06 14:57:54 UTC
[PR] Update rel.h: fix typo [cloudberry]
reshke opened a new pull request, #703:
URL: https://github.com/apache/cloudberry/pull/703
<!--Thank you for contributing!-->
<!--In case of an existing issue or discussions, please reference it-->
fix #ISSUE_Number
<!--Remove this section if no corresponding issue.-->
---
### Change logs
_Describe your change clearly, including what problem is being solved or what feature is being added._
_If it has some breaking backward or forward compatibility, please clary._
### Why are the changes needed?
_Describe why the changes are necessary._
### Does this PR introduce any user-facing change?
_If yes, please clarify the previous behavior and the change this PR proposes._
### How was this patch tested?
_Please detail how the changes were tested, including manual tests and any relevant unit or integration tests._
### Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
- [ ] Make sure your Pull Request has a clear title and commit message. You can take [git-commit](https://github.com/cloudberrydb/cloudberrydb/blob/main/.gitmessage) template as a reference.
- [ ] Sign the Contributor License Agreement as prompted for your first-time contribution(*One-time setup*).
- [ ] Learn the [coding contribution guide](https://cloudberrydb.org/contribute/code), including our code conventions, workflow and more.
- [ ] List your communication in the [GitHub Issues](https://github.com/cloudberrydb/cloudberrydb/issues) or [Discussions](https://github.com/orgs/cloudberrydb/discussions) (if has or needed).
- [ ] Document changes.
- [ ] Add tests for the change
- [ ] Pass `make installcheck`
- [ ] Pass `make -C src/test installcheck-cbdb-parallel`
- [ ] Feel free to request `cloudberrydb/dev` team for review and approval when your PR is ready🥳
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Update rel.h: fix typo [cloudberry]
Posted by "reshke (via GitHub)" <gi...@apache.org>.
reshke closed pull request #703: Update rel.h: fix typo
URL: https://github.com/apache/cloudberry/pull/703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Update rel.h: fix typo [cloudberry]
Posted by "avamingli (via GitHub)" <gi...@apache.org>.
avamingli commented on code in PR #703:
URL: https://github.com/apache/cloudberry/pull/703#discussion_r1831976842
##########
src/include/utils/rel.h:
##########
@@ -705,7 +705,7 @@ typedef struct ViewOptions
* RelationUsesLocalBuffers
* True if relation's pages are stored in local buffers.
*
- * In GPDB, we do not use local buffers for temp tables because segmates need
+ * In GPDB, we do not use local buffers for temp tables because segments need
* to share temp table contents. Currently, there is no other reason to use
* local buffers.
Review Comment:
Hmm.. I'm not sure it's a typo or intended.
`segmates` are special Gang in GPDB.
We'd better make sure what the comments said about `segmates` word.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org