You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2024/07/04 10:22:37 UTC
(commons-rng) 04/31: Remove modification of x inline
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit 32f294faf773f2c047b0dff403c4f267099f2c5c
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Wed Jul 3 14:02:13 2024 +0100
Remove modification of x inline
---
.../src/main/java/org/apache/commons/rng/core/BaseProvider.java | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/commons-rng-core/src/main/java/org/apache/commons/rng/core/BaseProvider.java b/commons-rng-core/src/main/java/org/apache/commons/rng/core/BaseProvider.java
index 164258fa..5bf39309 100644
--- a/commons-rng-core/src/main/java/org/apache/commons/rng/core/BaseProvider.java
+++ b/commons-rng-core/src/main/java/org/apache/commons/rng/core/BaseProvider.java
@@ -340,7 +340,8 @@ public abstract class BaseProvider
// Fill the rest as if using a SplitMix64 RNG
long x = s[0];
for (int i = seed.length; i < length; i++) {
- s[i] = stafford13(x += GOLDEN_RATIO_64);
+ x += GOLDEN_RATIO_64;
+ s[i] = stafford13(x);
}
return s;
}
@@ -390,7 +391,8 @@ public abstract class BaseProvider
// Fill the rest as if using a SplitMix64-style RNG for 32-bit output
int x = s[0];
for (int i = seed.length; i < length; i++) {
- s[i] = murmur3(x += GOLDEN_RATIO_32);
+ x += GOLDEN_RATIO_32;
+ s[i] = murmur3(x);
}
return s;
}