You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/04/30 17:52:23 UTC
[GitHub] [jackrabbit-oak] MarcyGO opened a new pull request, #555: Fix sweep2 test
MarcyGO opened a new pull request, #555:
URL: https://github.com/apache/jackrabbit-oak/pull/555
The test `org.apache.jackrabbit.oak.plugins.document.Sweep2Test#testSweep2Uncommitted` can fail based on the order of iteration in `HashMap`. I found the issue using [NonDex](https://github.com/TestingResearchIllinois/NonDex):
```
mvn install -DskipTests -pl oak-store-document -am
mvn -pl oak-store-document edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=org.apache.jackrabbit.oak.plugins.document.Sweep2Test#testSweep2Uncommitted
```
The proposed fix changes several `HashMap` to `LinkedHashMap`, which has determinate iteration order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] mreutegg commented on pull request #555: Fix indeterminate map ordering that may causes Sweep2Test to fail
Posted by GitBox <gi...@apache.org>.
mreutegg commented on PR #555:
URL: https://github.com/apache/jackrabbit-oak/pull/555#issuecomment-1115788960
@MarcyGO please create a JIRA issue for this PR.
Preferably the PR should also have a unit test that reproduces the issue reliably.
I'm not sure the fix is done at the appropriate place. The proposed changes are in module oak-store-spi. Does the current implementation of those two classes really require a determinate iteration order or is it rather Sweep2Test that makes assumptions about an implementation detail? Maybe just the test should be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix indeterminate map ordering that may causes Sweep2Test to fail [jackrabbit-oak]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #555:
URL: https://github.com/apache/jackrabbit-oak/pull/555#issuecomment-2092010178
This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org