You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Gregory Chanan <gc...@cloudera.com> on 2013/12/05 01:43:33 UTC

Review Request 16025: SENTRY-68: Give sentry-solr-binding the ability to authenticate via kerberos

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16025/
-----------------------------------------------------------

Review request for sentry, Brock Noland and Shreepadma Venugopalan.


Repository: sentry


Description
-------

solr lazily authenticates with HDFS, and there can be a race between when solr authenticates and when sentry would try to read the .ini file off of HDFS.

I don't think this is an issue with sentry and hive; AFAIK hive will already be authenticated by the time sentry runs in that case.

This patch gives the solr sentry binding the ability to authenticate via kerberos.


Diffs
-----

  sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java 5c2d7bc 

Diff: https://reviews.apache.org/r/16025/diff/


Testing
-------

Ran the unit tests successfully and tried the new sentry on a solr cluster and it worked.


Thanks,

Gregory Chanan


Re: Review Request 16025: SENTRY-68: Give sentry-solr-binding the ability to authenticate via kerberos

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16025/#review29813
-----------------------------------------------------------

Ship it!


Ship It!

- Brock Noland


On Dec. 5, 2013, 12:43 a.m., Gregory Chanan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16025/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2013, 12:43 a.m.)
> 
> 
> Review request for sentry, Brock Noland and Shreepadma Venugopalan.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> solr lazily authenticates with HDFS, and there can be a race between when solr authenticates and when sentry would try to read the .ini file off of HDFS.
> 
> I don't think this is an issue with sentry and hive; AFAIK hive will already be authenticated by the time sentry runs in that case.
> 
> This patch gives the solr sentry binding the ability to authenticate via kerberos.
> 
> 
> Diffs
> -----
> 
>   sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java 5c2d7bc 
> 
> Diff: https://reviews.apache.org/r/16025/diff/
> 
> 
> Testing
> -------
> 
> Ran the unit tests successfully and tried the new sentry on a solr cluster and it worked.
> 
> 
> Thanks,
> 
> Gregory Chanan
> 
>