You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ma...@apache.org on 2020/07/12 19:59:41 UTC
[lucene-solr] branch reference_impl updated (7fcad7d -> 82aea4c)
This is an automated email from the ASF dual-hosted git repository.
markrmiller pushed a change to branch reference_impl
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git.
from 7fcad7d #97 Whoops - tweak this test annotation for now.
new 257d870 #98 Sync this and see what happens.
new 82aea4c #98 Perf buff, remove a lot of garbage allocation.
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
solr/core/src/java/org/apache/solr/schema/IndexSchema.java | 4 ++--
solr/test-framework/src/java/org/apache/solr/SolrTestCase.java | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
[lucene-solr] 02/02: #98 Perf buff,
remove a lot of garbage allocation.
Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
markrmiller pushed a commit to branch reference_impl
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
commit 82aea4c44cf75b7d3f3b99d5fabc115b425b1af6
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Sun Jul 12 14:59:26 2020 -0500
#98 Perf buff, remove a lot of garbage allocation.
---
solr/test-framework/src/java/org/apache/solr/SolrTestCase.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/solr/test-framework/src/java/org/apache/solr/SolrTestCase.java b/solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
index 9af109d..d98719a 100644
--- a/solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
+++ b/solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
@@ -181,7 +181,7 @@ public class SolrTestCase extends LuceneTestCase {
// can make things quite slow
System.setProperty("solr.disableJmxReporter", "true");
System.setProperty("solr.skipCommitOnClose", "true");
- // System.setProperty("solr.skipReloadSPI", "true");
+ System.setProperty("solr.skipReloadSPI", "true"); // can generate tons of URL garbage and can happen too often
System.setProperty("solr.OverseerStateUpdateDelay", "1000");
[lucene-solr] 01/02: #98 Sync this and see what happens.
Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
markrmiller pushed a commit to branch reference_impl
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
commit 257d87022d79d86cb9a0d0f33d89d129b58cb258
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Sun Jul 12 14:59:08 2020 -0500
#98 Sync this and see what happens.
---
solr/core/src/java/org/apache/solr/schema/IndexSchema.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/solr/core/src/java/org/apache/solr/schema/IndexSchema.java b/solr/core/src/java/org/apache/solr/schema/IndexSchema.java
index 7fac59b..6bb1b95 100644
--- a/solr/core/src/java/org/apache/solr/schema/IndexSchema.java
+++ b/solr/core/src/java/org/apache/solr/schema/IndexSchema.java
@@ -814,9 +814,9 @@ public class IndexSchema {
* @param fields The sequence of {@link org.apache.solr.schema.SchemaField}
*/
public void registerDynamicFields(SchemaField... fields) {
- List<DynamicField> dynFields = new ArrayList<>(asList(dynamicFields));
+ List<DynamicField> dynFields = Collections.synchronizedList(new ArrayList<>(asList(dynamicFields)));
for (SchemaField field : fields) {
- if (isDuplicateDynField(dynFields, field)) {
+ if (isDuplicateDynField(dynFields, field)) { Collections.synchronizedList(new ArrayList<>(asList(dynamicFields)));
if (log.isDebugEnabled()) {
log.debug("dynamic field already exists: dynamic field: [{}]", field.getName());
}