You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by toyboxman <gi...@git.apache.org> on 2018/08/08 14:52:36 UTC
[GitHub] incubator-griffin pull request #388: Fix bugs about code style violation aga...
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/388
Fix bugs about code style violation against Griffin rules
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin wrap
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-griffin/pull/388.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #388
----
commit e61a515ce91630cc229e7ddb549b200f7653f000
Author: Eugene <to...@...>
Date: 2018-08-07T14:11:32Z
Fix bugs about code style violation against Griffin rules
----
---
[GitHub] incubator-griffin issue #388: Fix bugs about code style violation against Gr...
Posted by toyboxman <gi...@git.apache.org>.
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/388
@guoyuepeng
William,
I'll resolve those conflicts. any question, let me know
---
[GitHub] incubator-griffin issue #388: Fix bugs about code style violation against Gr...
Posted by toyboxman <gi...@git.apache.org>.
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/388
@guoyuepeng
William,
I see recent changes still have some violations against basic code style rules. like import statement using * instead of concrete class name, too long code line over 100 characters etc.
as a good opensource product, style is first glance of code quality.
---
[GitHub] incubator-griffin pull request #388: Fix bugs about code style violation aga...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-griffin/pull/388
---
[GitHub] incubator-griffin issue #388: Fix bugs about code style violation against Gr...
Posted by toyboxman <gi...@git.apache.org>.
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/388
conflicts have been resolved
---
[GitHub] incubator-griffin issue #388: Fix bugs about code style violation against Gr...
Posted by guoyuepeng <gi...@git.apache.org>.
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/388
@toyboxman
hi Jin,
There are some conflicts, could you try to sync it and submit the PR again?
Thanks,
William
---