You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2025/04/23 12:16:10 UTC

Re: [PR] [improve][io] Support Protobuf schema for Kafka source connector [pulsar]

lhotari commented on code in PR #23954:
URL: https://github.com/apache/pulsar/pull/23954#discussion_r2055392879


##########
pulsar-io/kafka/pom.xml:
##########
@@ -104,6 +104,12 @@
       <version>${confluent.version}</version>
     </dependency>
 
+    <dependency>
+      <groupId>io.confluent</groupId>
+      <artifactId>kafka-protobuf-serializer</artifactId>
+      <version>${confluent.version}</version>

Review Comment:
   I think it's time to bump `confluent.version`. It's currently `6.2.8` which was released on Dec 16, 2022. [Available versions](https://mvnrepository.com/artifact/io.confluent/kafka-protobuf-serializer).
   
   I have created a separate PR to upgrade confluent platform version and kafka client version, #24201.
   Since it addresses CVEs, I believe that it would be useful to first merge it and then rebase this PR after that to ensure that changes are compatible with recent versions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org