You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/04/19 18:19:57 UTC
[GitHub] [hive] asinkovits opened a new pull request, #3223: HIVE-26155: Create a new connection pool for compaction
asinkovits opened a new pull request, #3223:
URL: https://github.com/apache/hive/pull/3223
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Create a new connection pool for compaction
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To prevent compaction to use up all the connections in the default connection pool.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Manual tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #3223: HIVE-26155: Create a new connection pool for compaction
Posted by GitBox <gi...@apache.org>.
pvary commented on PR #3223:
URL: https://github.com/apache/hive/pull/3223#issuecomment-1108419421
Wait!
This could cause dead locks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a diff in pull request #3223: HIVE-26155: Create a new connection pool for compaction
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on code in PR #3223:
URL: https://github.com/apache/hive/pull/3223#discussion_r855948450
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -5836,11 +5835,11 @@ private void removeTxnsFromMinHistoryLevel(Connection dbConn, List<Long> txnids)
}
}
- private synchronized static DataSource setupJdbcConnectionPool(Configuration conf, int maxPoolSize, long getConnectionTimeoutMs) {
+ protected synchronized static DataSource setupJdbcConnectionPool(Configuration conf, int maxPoolSize) {
Review Comment:
Could we add @Override if we override parent method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a diff in pull request #3223: HIVE-26155: Create a new connection pool for compaction
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on code in PR #3223:
URL: https://github.com/apache/hive/pull/3223#discussion_r855946205
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java:
##########
@@ -45,15 +45,19 @@ public class HikariCPDataSourceProvider implements DataSourceProvider {
@Override
public DataSource create(Configuration hdpConfig) throws SQLException {
+ int maxPoolSize = MetastoreConf.getIntVar(hdpConfig,
Review Comment:
Could we extract this into the default method in the interface since we always use the same conf - MetastoreConf.ConfVars.CONNECTION_POOLING_MAX_CONNECTIONS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] asinkovits commented on a diff in pull request #3223: HIVE-26155: Create a new connection pool for compaction
Posted by GitBox <gi...@apache.org>.
asinkovits commented on code in PR #3223:
URL: https://github.com/apache/hive/pull/3223#discussion_r856193879
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -5836,11 +5835,11 @@ private void removeTxnsFromMinHistoryLevel(Connection dbConn, List<Long> txnids)
}
}
- private synchronized static DataSource setupJdbcConnectionPool(Configuration conf, int maxPoolSize, long getConnectionTimeoutMs) {
+ protected synchronized static DataSource setupJdbcConnectionPool(Configuration conf, int maxPoolSize) {
Review Comment:
I'm not overriding this method, just changed the visibility and removed getConnectionTimeoutMs param as it was not used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a diff in pull request #3223: HIVE-26155: Create a new connection pool for compaction
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on code in PR #3223:
URL: https://github.com/apache/hive/pull/3223#discussion_r859708999
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -5836,11 +5835,11 @@ private void removeTxnsFromMinHistoryLevel(Connection dbConn, List<Long> txnids)
}
}
- private synchronized static DataSource setupJdbcConnectionPool(Configuration conf, int maxPoolSize, long getConnectionTimeoutMs) {
+ protected synchronized static DataSource setupJdbcConnectionPool(Configuration conf, int maxPoolSize) {
Review Comment:
oh, it's in TxnHandler, my bad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] asinkovits merged pull request #3223: HIVE-26155: Create a new connection pool for compaction
Posted by GitBox <gi...@apache.org>.
asinkovits merged PR #3223:
URL: https://github.com/apache/hive/pull/3223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org