You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Wang Xu (JIRA)" <ji...@apache.org> on 2010/09/17 01:12:34 UTC

[jira] Created: (HDFS-1405) Make FSVolumeSet in FSDataSet pluggable

Make FSVolumeSet in FSDataSet pluggable
---------------------------------------

                 Key: HDFS-1405
                 URL: https://issues.apache.org/jira/browse/HDFS-1405
             Project: Hadoop HDFS
          Issue Type: Improvement
    Affects Versions: 0.22.0
            Reporter: Wang Xu
            Assignee: Wang Xu


I am trying to submit a patch for HDFS-1362, which enable online add or remove a volume of a serving DataNode.

I managed to create the patch  avoiding modify exist class, but FSVolumeSet is an exception, the member "volumes" is an array, while I need a List to facilitate the hotplug procedure. Thus I have 2 possible solutions:
* Provide a abstract class as its super class, with the definition of all its methods. OR
* Modify the volumes' definition in FSVolumeSet, as a Gereral Type Collection<>, which may use different implementation in subclasses.

I will supply a patch for the first method for review

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HDFS-1405) Make FSVolumeSet in FSDataSet pluggable

Posted by "Wang Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wang Xu updated HDFS-1405:
--------------------------

    Attachment: HDFS-1405.txt

This patch defined a abstract super class AbstractFSVolumeSet for FSVolumeSet which facilitate different volumes organization methods implementing in other subclasses.

shutdown() and getVolumeInfo() are also defined to avoid direct access to memvers of FSVolumeSet.

> Make FSVolumeSet in FSDataSet pluggable
> ---------------------------------------
>
>                 Key: HDFS-1405
>                 URL: https://issues.apache.org/jira/browse/HDFS-1405
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Wang Xu
>            Assignee: Wang Xu
>         Attachments: HDFS-1405.txt
>
>
> I am trying to submit a patch for HDFS-1362, which enable online add or remove a volume of a serving DataNode.
> I managed to create the patch  avoiding modify exist class, but FSVolumeSet is an exception, the member "volumes" is an array, while I need a List to facilitate the hotplug procedure. Thus I have 2 possible solutions:
> * Provide a abstract class as its super class, with the definition of all its methods. OR
> * Modify the volumes' definition in FSVolumeSet, as a Gereral Type Collection<>, which may use different implementation in subclasses.
> I will supply a patch for the first method for review

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HDFS-1405) Make FSVolumeSet in FSDataSet pluggable

Posted by "Wang Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wang Xu updated HDFS-1405:
--------------------------

    Attachment: HDFS-1405v3.txt

With some related changes in DataNode, DataBlockScanner, etc.

> Make FSVolumeSet in FSDataSet pluggable
> ---------------------------------------
>
>                 Key: HDFS-1405
>                 URL: https://issues.apache.org/jira/browse/HDFS-1405
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Wang Xu
>            Assignee: Wang Xu
>         Attachments: HDFS-1405.txt, HDFS-1405v2.txt, HDFS-1405v3.txt
>
>
> I am trying to submit a patch for HDFS-1362, which enable online add or remove a volume of a serving DataNode.
> I managed to create the patch  avoiding modify exist class, but FSVolumeSet is an exception, the member "volumes" is an array, while I need a List to facilitate the hotplug procedure. Thus I have 2 possible solutions:
> * Provide a abstract class as its super class, with the definition of all its methods. OR
> * Modify the volumes' definition in FSVolumeSet, as a Gereral Type Collection<>, which may use different implementation in subclasses.
> I will supply a patch for the first method for review

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HDFS-1405) Make FSVolumeSet in FSDataSet pluggable

Posted by "Wang Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wang Xu updated HDFS-1405:
--------------------------

    Attachment: HDFS-1405v2.txt

Additional modification to FSDatasetAsyncDiskService, allow its subclasses access the Hashmap and constants

> Make FSVolumeSet in FSDataSet pluggable
> ---------------------------------------
>
>                 Key: HDFS-1405
>                 URL: https://issues.apache.org/jira/browse/HDFS-1405
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Wang Xu
>            Assignee: Wang Xu
>         Attachments: HDFS-1405.txt, HDFS-1405v2.txt
>
>
> I am trying to submit a patch for HDFS-1362, which enable online add or remove a volume of a serving DataNode.
> I managed to create the patch  avoiding modify exist class, but FSVolumeSet is an exception, the member "volumes" is an array, while I need a List to facilitate the hotplug procedure. Thus I have 2 possible solutions:
> * Provide a abstract class as its super class, with the definition of all its methods. OR
> * Modify the volumes' definition in FSVolumeSet, as a Gereral Type Collection<>, which may use different implementation in subclasses.
> I will supply a patch for the first method for review

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HDFS-1405) Make FSVolumeSet in FSDataSet pluggable

Posted by "Wang Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wang Xu updated HDFS-1405:
--------------------------

    Component/s: data-node

This is for DataNode component

> Make FSVolumeSet in FSDataSet pluggable
> ---------------------------------------
>
>                 Key: HDFS-1405
>                 URL: https://issues.apache.org/jira/browse/HDFS-1405
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Wang Xu
>            Assignee: Wang Xu
>
> I am trying to submit a patch for HDFS-1362, which enable online add or remove a volume of a serving DataNode.
> I managed to create the patch  avoiding modify exist class, but FSVolumeSet is an exception, the member "volumes" is an array, while I need a List to facilitate the hotplug procedure. Thus I have 2 possible solutions:
> * Provide a abstract class as its super class, with the definition of all its methods. OR
> * Modify the volumes' definition in FSVolumeSet, as a Gereral Type Collection<>, which may use different implementation in subclasses.
> I will supply a patch for the first method for review

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.