You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2011/10/04 01:09:43 UTC
svn commit: r1178627 - /lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexReader.java

Author: mikemccand
Date: Mon Oct  3 23:09:43 2011
New Revision: 1178627

URL: http://svn.apache.org/viewvc?rev=1178627&view=rev
Log:
LUCENE-3464: add asserts

Modified:
    lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexReader.java

Modified: lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexReader.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexReader.java?rev=1178627&r1=1178626&r2=1178627&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexReader.java (original)
+++ lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexReader.java Mon Oct  3 23:09:43 2011
@@ -571,7 +571,9 @@ public abstract class IndexReader implem
    * IndexReader instance which you must eventually close
    */  
   public static IndexReader openIfChanged(IndexReader oldReader) throws IOException {
-    return oldReader.doOpenIfChanged();
+    final IndexReader newReader = oldReader.doOpenIfChanged();
+    assert newReader != oldReader;
+    return newReader;
   }
 
   /**
@@ -583,7 +585,9 @@ public abstract class IndexReader implem
    * @see #openIfChanged(IndexReader)
    */
   public static IndexReader openIfChanged(IndexReader oldReader, boolean readOnly) throws IOException {
-    return oldReader.doOpenIfChanged(readOnly);
+    final IndexReader newReader = oldReader.doOpenIfChanged(readOnly);
+    assert newReader != oldReader;
+    return newReader;
   }
 
   /**
@@ -596,7 +600,9 @@ public abstract class IndexReader implem
    */
   // TODO: should you be able to specify readOnly?
   public static IndexReader openIfChanged(IndexReader oldReader, IndexCommit commit) throws IOException {
-    return oldReader.doOpenIfChanged(commit);
+    final IndexReader newReader = oldReader.doOpenIfChanged(commit);
+    assert newReader != oldReader;
+    return newReader;
   }
 
   /**
@@ -661,7 +667,9 @@ public abstract class IndexReader implem
    * @lucene.experimental
    */
   public static IndexReader openIfChanged(IndexReader oldReader, IndexWriter writer, boolean applyAllDeletes) throws IOException {
-    return oldReader.doOpenIfChanged(writer, applyAllDeletes);
+    final IndexReader newReader = oldReader.doOpenIfChanged(writer, applyAllDeletes);
+    assert newReader != oldReader;
+    return newReader;
   }
 
   protected IndexReader doOpenIfChanged() throws CorruptIndexException, IOException {