[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6435: Add tpch test cases with data.

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6435:
URL: https://github.com/apache/arrow-datafusion/pull/6435#discussion_r1210728576


##########
.github/workflows/rust.yml:
##########
@@ -197,18 +197,17 @@ jobs:
           rust-version: stable
       - name: Generate benchmark data and expected query results
         run: |
-          mkdir -p benchmarks/data/answers
+          mkdir -p datafusion/core/tests/sqllogictests/test_files/tpch/data
           git clone https://github.com/databricks/tpch-dbgen.git
           cd tpch-dbgen
           make
-          ./dbgen -f -s 1
-          mv *.tbl ../benchmarks/data
-          mv ./answers/* ../benchmarks/data/answers/
+          ./dbgen -f -s 0.1

Review Comment:
   I looked into this a little more -- and note we are running this CI check sf 0.1 (rather than SF1) It seems like a good idea and means it takes only 8 seconds to make the data 👍 
   
   https://github.com/apache/arrow-datafusion/actions/runs/5108217213/jobs/9181887855?pr=6435



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org