[GitHub] [cloudstack] shwstppr commented on a change in pull request #5425: api: Update DNS on changing VM name

[GitBox <gi...@apache.org>]

shwstppr commented on a change in pull request #5425:
URL: https://github.com/apache/cloudstack/pull/5425#discussion_r705230327



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -2911,9 +2918,40 @@ public UserVm updateVirtualMachine(long id, String displayName, String group, Bo
             }
         }
 
+        if (!StringUtils.isEmpty(hostName)) {
+            vm.setHostName(hostName);
+            try {
+                updateDns(vm);
+            } catch (Exception e) {
+                throw new CloudRuntimeException(String.format("Failed to update hostname of VM %s to %s", vm.getInstanceName(), vm.getHostName()));
+            }

Review comment:
       @Pearl1594 do we need to really catch everything here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org