You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/29 15:20:03 UTC

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1410: MINIFICPP-1500 Fix multiple archive tests running in parallel

lordgamez opened a new pull request, #1410:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1410

   The `NonRepeatingStringGenerator` only generated an initial prefix from the current timestamp's millisecond count. Because of this if multiple ArchiveTests (FocusArchiveTests and ManipulateArchiveTests) were run in parallel it could occur, that they generated the same temp filename due to the same timestamp. This caused failures as the different test suites manipulated each other's test files.
   
   https://issues.apache.org/jira/browse/MINIFICPP-1500
   
   ----------------------------------
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1410: MINIFICPP-1500 Fix multiple archive tests running in parallel

Posted by GitBox <gi...@apache.org>.
lordgamez commented on code in PR #1410:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1410#discussion_r963719514


##########
libminifi/include/utils/Id.h:
##########
@@ -126,12 +126,12 @@ class NonRepeatingStringGenerator {
   std::string generate() {
     return prefix_ + std::to_string(incrementor_++);
   }
-    uint64_t generateId() {
-      return incrementor_++;
-    }
+  uint64_t generateId() {
+    return incrementor_++;
+  }
  private:
   std::atomic<uint64_t> incrementor_{0};
-  std::string prefix_{std::to_string(std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::system_clock::now().time_since_epoch()).count()) + "-"};
+  std::string prefix_{IdGenerator::getIdGenerator()->generate().to_string() + "-"};

Review Comment:
   It's not the tests that create temporary files, but the libarchive. `FocusArchiveEntry::ReadCallback` which is used in both `ManipulateArchive` and `FocusArchiveEntry` processors [creates a temporary file when extracting the archive](https://github.com/apache/nifi-minifi-cpp/blob/a3835e1938db1287b0063d159b453b8a70f7a48b/extensions/libarchive/FocusArchiveEntry.cpp#L212) which only uses the timestamp as the filename. When the tests for `ManipulateArchive` and `FocusArchiveEntry` run in parallel the timestamp can be the same for the extraction and they override each other's temporary files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1410: MINIFICPP-1500 Fix multiple archive tests running in parallel

Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on code in PR #1410:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1410#discussion_r963761621


##########
libminifi/include/utils/Id.h:
##########
@@ -126,12 +126,12 @@ class NonRepeatingStringGenerator {
   std::string generate() {
     return prefix_ + std::to_string(incrementor_++);
   }
-    uint64_t generateId() {
-      return incrementor_++;
-    }
+  uint64_t generateId() {
+    return incrementor_++;
+  }
  private:
   std::atomic<uint64_t> incrementor_{0};
-  std::string prefix_{std::to_string(std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::system_clock::now().time_since_epoch()).count()) + "-"};
+  std::string prefix_{IdGenerator::getIdGenerator()->generate().to_string() + "-"};

Review Comment:
   I see, thanks for the clarification 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1410: MINIFICPP-1500 Fix multiple archive tests running in parallel

Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on code in PR #1410:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1410#discussion_r963699187


##########
libminifi/include/utils/Id.h:
##########
@@ -126,12 +126,12 @@ class NonRepeatingStringGenerator {
   std::string generate() {
     return prefix_ + std::to_string(incrementor_++);
   }
-    uint64_t generateId() {
-      return incrementor_++;
-    }
+  uint64_t generateId() {
+    return incrementor_++;
+  }
  private:
   std::atomic<uint64_t> incrementor_{0};
-  std::string prefix_{std::to_string(std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::system_clock::now().time_since_epoch()).count()) + "-"};
+  std::string prefix_{IdGenerator::getIdGenerator()->generate().to_string() + "-"};

Review Comment:
   what files are accessed in parallel? (the tests seem to create separate temporary directories)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1410: MINIFICPP-1500 Fix multiple archive tests running in parallel

Posted by GitBox <gi...@apache.org>.
fgerlits closed pull request #1410: MINIFICPP-1500 Fix multiple archive tests running in parallel
URL: https://github.com/apache/nifi-minifi-cpp/pull/1410


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org