You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Zoltan Haindrich (Jira)" <ji...@apache.org> on 2020/06/04 09:06:00 UTC

[jira] [Commented] (HIVE-23527) CUME_DIST should be threated as a function returning double

    [ https://issues.apache.org/jira/browse/HIVE-23527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125715#comment-17125715 ] 

Zoltan Haindrich commented on HIVE-23527:
-----------------------------------------

HIVE-23462 contains a more conservative version of this patch - which also fixes the "returning double part"

> CUME_DIST should be threated as a function returning double
> -----------------------------------------------------------
>
>                 Key: HIVE-23527
>                 URL: https://issues.apache.org/jira/browse/HIVE-23527
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>         Attachments: HIVE-23527.01.patch, HIVE-23527.01.patch
>
>
> right now it is handled as integer in calcite - which might cause some trouble (at least for me)
> Interestingly enough it seems like only percent_rank has double type
> https://github.com/apache/hive/blob/b047cfae872244e769f5d1c3c11811d1c49c19ad/ql/src/java/org/apache/hadoop/hive/ql/parse/type/HiveFunctionHelper.java#L392
> since this change goes back to HIVE-9133 and seems to me that removing this tweak is just works - I'll submit a patch to remove this conditional



--
This message was sent by Atlassian Jira
(v8.3.4#803005)