You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Deepak Barr <de...@gmail.com> on 2015/07/30 11:27:19 UTC
Review Request 36934: The file size is obtained using Hadoop
FileSystem APIs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36934/
-----------------------------------------------------------
Review request for lens, Jaideep dhok and Pranav Agarwal.
Bugs: LENS-651
https://issues.apache.org/jira/browse/LENS-651
Repository: lens
Description
-------
Added file size in the /resultset api response in case of persistent resultset
Diffs
-----
incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java 70dac08
incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 3d1f20a
incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 82b0568
incubator-lens/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java f80cdd8
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 48e020f
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java 2c48209
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java 270f0f0
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java cc6d918
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java af354cc
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java 13f069f
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 0c78e01
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 1d2e89b
incubator-lens/lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java ea24336
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 80eb697
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 1904350
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1316257
Diff: https://reviews.apache.org/r/36934/diff/
Testing
-------
Yes.
Thanks,
Deepak Barr
Re: Review Request 36934: The file size is obtained using Hadoop
FileSystem APIs
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36934/#review93577
-----------------------------------------------------------
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java (line 43)
<https://reviews.apache.org/r/36934/#comment147959>
Can we move this only to PersistentResultSet? fileSize is not applicable for Inmemory result set.
- Amareshwari Sriramadasu
On July 30, 2015, 9:27 a.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36934/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 9:27 a.m.)
>
>
> Review request for lens, Jaideep dhok and Pranav Agarwal.
>
>
> Bugs: LENS-651
> https://issues.apache.org/jira/browse/LENS-651
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added file size in the /resultset api response in case of persistent resultset
>
>
> Diffs
> -----
>
> incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java 70dac08
> incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 3d1f20a
> incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 82b0568
> incubator-lens/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java f80cdd8
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 48e020f
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java 2c48209
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java 270f0f0
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java cc6d918
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java af354cc
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java 13f069f
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 0c78e01
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 1d2e89b
> incubator-lens/lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java ea24336
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 80eb697
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 1904350
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1316257
>
> Diff: https://reviews.apache.org/r/36934/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 36934: The file size is obtained using Hadoop
FileSystem APIs
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36934/#review93564
-----------------------------------------------------------
incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java (lines 63 - 70)
<https://reviews.apache.org/r/36934/#comment147945>
Can we convert types of these to `Integer`, `Long` etc instead of `int`, `long`? That will ensure that unnecessary transfer of 4 bytes per field will not happen if the values are `unknown`.
Then we can do away with using `-1` as a placeholder for `unknown`. using `null` would suffice.
- Rajat Khandelwal
On July 30, 2015, 2:57 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36934/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 2:57 p.m.)
>
>
> Review request for lens, Jaideep dhok and Pranav Agarwal.
>
>
> Bugs: LENS-651
> https://issues.apache.org/jira/browse/LENS-651
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added file size in the /resultset api response in case of persistent resultset
>
>
> Diffs
> -----
>
> incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java 70dac08
> incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 3d1f20a
> incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 82b0568
> incubator-lens/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java f80cdd8
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 48e020f
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java 2c48209
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java 270f0f0
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java cc6d918
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java af354cc
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java 13f069f
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 0c78e01
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 1d2e89b
> incubator-lens/lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java ea24336
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 80eb697
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 1904350
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1316257
>
> Diff: https://reviews.apache.org/r/36934/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 36934: The file size is obtained using Hadoop
FileSystem APIs
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36934/#review93578
-----------------------------------------------------------
Please include unit tests for file size assertions.
- Amareshwari Sriramadasu
On July 30, 2015, 9:27 a.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36934/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 9:27 a.m.)
>
>
> Review request for lens, Jaideep dhok and Pranav Agarwal.
>
>
> Bugs: LENS-651
> https://issues.apache.org/jira/browse/LENS-651
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added file size in the /resultset api response in case of persistent resultset
>
>
> Diffs
> -----
>
> incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java 70dac08
> incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 3d1f20a
> incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 82b0568
> incubator-lens/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java f80cdd8
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 48e020f
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java 2c48209
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java 270f0f0
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java cc6d918
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java af354cc
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java 13f069f
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 0c78e01
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 1d2e89b
> incubator-lens/lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java ea24336
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 80eb697
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 1904350
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1316257
>
> Diff: https://reviews.apache.org/r/36934/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 36934: The file size is obtained using Hadoop
FileSystem APIs
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36934/#review94671
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On Aug. 9, 2015, 5:24 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36934/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2015, 5:24 p.m.)
>
>
> Review request for lens, Jaideep dhok and Pranav Agarwal.
>
>
> Bugs: LENS-651
> https://issues.apache.org/jira/browse/LENS-651
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added file size in the /resultset api response in case of persistent resultset
>
>
> Diffs
> -----
>
> incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java 70dac08
> incubator-lens/lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 88facda
> incubator-lens/lens-driver-es/src/main/java/org/apache/lens/driver/es/client/ESResultSet.java 4ba2321
> incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 3d1f20a
> incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 82b0568
> incubator-lens/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java f80cdd8
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 48e020f
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java 2c48209
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java aa66b7b
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java cc6d918
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java af354cc
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java 13f069f
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 0c78e01
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 1d2e89b
> incubator-lens/lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 17dc99b
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 80eb697
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java e392e34
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2983db4
> incubator-lens/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java beaa247
>
> Diff: https://reviews.apache.org/r/36934/diff/
>
>
> Testing
> -------
>
> Yes.
>
> 1. Tested with various session conf for lens persistent,driver persistent and inmemory resultset.
> 2. Tested the output through APIs and CLI.
> 3. Tested with compressed result set and split resultset.
> 4. Tested the insertion and retrieval from finished queries table.
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 5.704 s]
> [INFO] Lens ............................................... SUCCESS [ 10.292 s]
> [INFO] Lens API ........................................... SUCCESS [ 38.121 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 33.306 s]
> [INFO] Lens Cube .......................................... SUCCESS [09:16 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 30.385 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 22.183 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [04:32 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 57.032 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 24.935 s]
> [INFO] Lens Server ........................................ SUCCESS [08:31 min]
> [INFO] Lens client ........................................ SUCCESS [ 49.693 s]
> [INFO] Lens CLI ........................................... SUCCESS [03:51 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 14.025 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 13.169 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [02:15 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.424 s]
> [INFO] Lens Regression .................................... SUCCESS [ 16.094 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:48 min
> [INFO] Finished at: 2015-08-09T15:54:05+05:30
> [INFO] Final Memory: 209M/2440M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 36934: The file size is obtained using Hadoop
FileSystem APIs
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36934/#review94698
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Aug. 9, 2015, 11:54 a.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36934/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2015, 11:54 a.m.)
>
>
> Review request for lens, Jaideep dhok and Pranav Agarwal.
>
>
> Bugs: LENS-651
> https://issues.apache.org/jira/browse/LENS-651
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added file size in the /resultset api response in case of persistent resultset
>
>
> Diffs
> -----
>
> incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java 70dac08
> incubator-lens/lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 88facda
> incubator-lens/lens-driver-es/src/main/java/org/apache/lens/driver/es/client/ESResultSet.java 4ba2321
> incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 3d1f20a
> incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 82b0568
> incubator-lens/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java f80cdd8
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 48e020f
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java 2c48209
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java aa66b7b
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java cc6d918
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java af354cc
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java 13f069f
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 0c78e01
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 1d2e89b
> incubator-lens/lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 17dc99b
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 80eb697
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java e392e34
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2983db4
> incubator-lens/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java beaa247
>
> Diff: https://reviews.apache.org/r/36934/diff/
>
>
> Testing
> -------
>
> Yes.
>
> 1. Tested with various session conf for lens persistent,driver persistent and inmemory resultset.
> 2. Tested the output through APIs and CLI.
> 3. Tested with compressed result set and split resultset.
> 4. Tested the insertion and retrieval from finished queries table.
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 5.704 s]
> [INFO] Lens ............................................... SUCCESS [ 10.292 s]
> [INFO] Lens API ........................................... SUCCESS [ 38.121 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 33.306 s]
> [INFO] Lens Cube .......................................... SUCCESS [09:16 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 30.385 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 22.183 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [04:32 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 57.032 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 24.935 s]
> [INFO] Lens Server ........................................ SUCCESS [08:31 min]
> [INFO] Lens client ........................................ SUCCESS [ 49.693 s]
> [INFO] Lens CLI ........................................... SUCCESS [03:51 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 14.025 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 13.169 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [02:15 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.424 s]
> [INFO] Lens Regression .................................... SUCCESS [ 16.094 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:48 min
> [INFO] Finished at: 2015-08-09T15:54:05+05:30
> [INFO] Final Memory: 209M/2440M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 36934: The file size is obtained using Hadoop
FileSystem APIs
Posted by Deepak Barr <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36934/
-----------------------------------------------------------
(Updated Aug. 9, 2015, 11:54 a.m.)
Review request for lens, Jaideep dhok and Pranav Agarwal.
Bugs: LENS-651
https://issues.apache.org/jira/browse/LENS-651
Repository: lens
Description
-------
Added file size in the /resultset api response in case of persistent resultset
Diffs
-----
incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java 70dac08
incubator-lens/lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 88facda
incubator-lens/lens-driver-es/src/main/java/org/apache/lens/driver/es/client/ESResultSet.java 4ba2321
incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 3d1f20a
incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 82b0568
incubator-lens/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java f80cdd8
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 48e020f
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java 2c48209
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java aa66b7b
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java cc6d918
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java af354cc
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java 13f069f
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 0c78e01
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 1d2e89b
incubator-lens/lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 17dc99b
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 80eb697
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java e392e34
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2983db4
incubator-lens/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java beaa247
Diff: https://reviews.apache.org/r/36934/diff/
Testing (updated)
-------
Yes.
1. Tested with various session conf for lens persistent,driver persistent and inmemory resultset.
2. Tested the output through APIs and CLI.
3. Tested with compressed result set and split resultset.
4. Tested the insertion and retrieval from finished queries table.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 5.704 s]
[INFO] Lens ............................................... SUCCESS [ 10.292 s]
[INFO] Lens API ........................................... SUCCESS [ 38.121 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 33.306 s]
[INFO] Lens Cube .......................................... SUCCESS [09:16 min]
[INFO] Lens DB storage .................................... SUCCESS [ 30.385 s]
[INFO] Lens Query Library ................................. SUCCESS [ 22.183 s]
[INFO] Lens Hive Driver ................................... SUCCESS [04:32 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 57.032 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 24.935 s]
[INFO] Lens Server ........................................ SUCCESS [08:31 min]
[INFO] Lens client ........................................ SUCCESS [ 49.693 s]
[INFO] Lens CLI ........................................... SUCCESS [03:51 min]
[INFO] Lens Examples ...................................... SUCCESS [ 14.025 s]
[INFO] Lens Distribution .................................. SUCCESS [ 13.169 s]
[INFO] Lens ML Lib ........................................ SUCCESS [02:15 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.424 s]
[INFO] Lens Regression .................................... SUCCESS [ 16.094 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 33:48 min
[INFO] Finished at: 2015-08-09T15:54:05+05:30
[INFO] Final Memory: 209M/2440M
[INFO] ------------------------------------------------------------------------
Thanks,
Deepak Barr
Re: Review Request 36934: The file size is obtained using Hadoop
FileSystem APIs
Posted by Deepak Barr <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36934/
-----------------------------------------------------------
(Updated Aug. 9, 2015, 11:16 a.m.)
Review request for lens, Jaideep dhok and Pranav Agarwal.
Bugs: LENS-651
https://issues.apache.org/jira/browse/LENS-651
Repository: lens
Description
-------
Added file size in the /resultset api response in case of persistent resultset
Diffs (updated)
-----
incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java 70dac08
incubator-lens/lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 88facda
incubator-lens/lens-driver-es/src/main/java/org/apache/lens/driver/es/client/ESResultSet.java 4ba2321
incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 3d1f20a
incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 82b0568
incubator-lens/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java f80cdd8
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 48e020f
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java 2c48209
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java aa66b7b
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java cc6d918
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java af354cc
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java 13f069f
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 0c78e01
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 1d2e89b
incubator-lens/lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 17dc99b
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 80eb697
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java e392e34
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2983db4
incubator-lens/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java beaa247
Diff: https://reviews.apache.org/r/36934/diff/
Testing
-------
Yes.
1. Tested with various session conf for lens persistent,driver persistent and inmemory resultset.
2. Tested the output through APIs and CLI.
3. Tested with compressed result set and split resultset.
4. Tested the insertion and retrieval from finished queries table.
Thanks,
Deepak Barr
Re: Review Request 36934: The file size is obtained using Hadoop
FileSystem APIs
Posted by Deepak Barr <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36934/
-----------------------------------------------------------
(Updated Aug. 9, 2015, 11:14 a.m.)
Review request for lens, Jaideep dhok and Pranav Agarwal.
Bugs: LENS-651
https://issues.apache.org/jira/browse/LENS-651
Repository: lens
Description
-------
Added file size in the /resultset api response in case of persistent resultset
Diffs (updated)
-----
incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java 70dac08
incubator-lens/lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 88facda
incubator-lens/lens-driver-es/src/main/java/org/apache/lens/driver/es/client/ESResultSet.java 4ba2321
incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 3d1f20a
incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 82b0568
incubator-lens/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java f80cdd8
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 48e020f
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java 2c48209
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java aa66b7b
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java cc6d918
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java af354cc
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java 13f069f
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 0c78e01
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 1d2e89b
incubator-lens/lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 17dc99b
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 80eb697
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java e392e34
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2983db4
incubator-lens/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java beaa247
Diff: https://reviews.apache.org/r/36934/diff/
Testing
-------
Yes.
1. Tested with various session conf for lens persistent,driver persistent and inmemory resultset.
2. Tested the output through APIs and CLI.
3. Tested with compressed result set and split resultset.
4. Tested the insertion and retrieval from finished queries table.
Thanks,
Deepak Barr
Re: Review Request 36934: The file size is obtained using Hadoop
FileSystem APIs
Posted by Deepak Barr <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36934/
-----------------------------------------------------------
(Updated Aug. 8, 2015, 5:51 p.m.)
Review request for lens, Jaideep dhok and Pranav Agarwal.
Bugs: LENS-651
https://issues.apache.org/jira/browse/LENS-651
Repository: lens
Description
-------
Added file size in the /resultset api response in case of persistent resultset
Diffs
-----
incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java 70dac08
incubator-lens/lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 88facda
incubator-lens/lens-driver-es/src/main/java/org/apache/lens/driver/es/client/ESResultSet.java 4ba2321
incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 3d1f20a
incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 82b0568
incubator-lens/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java f80cdd8
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 48e020f
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java 2c48209
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java aa66b7b
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java cc6d918
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java af354cc
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java 13f069f
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 0c78e01
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 1d2e89b
incubator-lens/lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 17dc99b
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 80eb697
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java e392e34
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2983db4
incubator-lens/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java beaa247
Diff: https://reviews.apache.org/r/36934/diff/
Testing (updated)
-------
Yes.
1. Tested with various session conf for lens persistent,driver persistent and inmemory resultset.
2. Tested the output through APIs and CLI.
3. Tested with compressed result set and split resultset.
4. Tested the insertion and retrieval from finished queries table.
Thanks,
Deepak Barr
Re: Review Request 36934: The file size is obtained using Hadoop
FileSystem APIs
Posted by Deepak Barr <de...@gmail.com>.
> On Aug. 8, 2015, 6:47 a.m., Rajat Khandelwal wrote:
> > incubator-lens/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java, line 831
> > <https://reviews.apache.org/r/36934/diff/2/?file=1035196#file1035196line831>
> >
> > Would it make sense to sum all file sizes in the directory?
Sum of size of all files in a directory can not asserted. This is because formatting would not happen if the final outputpath is a directory and fileSize is computed during formatting.
- Deepak
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36934/#review94621
-----------------------------------------------------------
On Aug. 9, 2015, 11:16 a.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36934/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2015, 11:16 a.m.)
>
>
> Review request for lens, Jaideep dhok and Pranav Agarwal.
>
>
> Bugs: LENS-651
> https://issues.apache.org/jira/browse/LENS-651
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added file size in the /resultset api response in case of persistent resultset
>
>
> Diffs
> -----
>
> incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java 70dac08
> incubator-lens/lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 88facda
> incubator-lens/lens-driver-es/src/main/java/org/apache/lens/driver/es/client/ESResultSet.java 4ba2321
> incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 3d1f20a
> incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 82b0568
> incubator-lens/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java f80cdd8
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 48e020f
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java 2c48209
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java aa66b7b
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java cc6d918
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java af354cc
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java 13f069f
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 0c78e01
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 1d2e89b
> incubator-lens/lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 17dc99b
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 80eb697
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java e392e34
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2983db4
> incubator-lens/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java beaa247
>
> Diff: https://reviews.apache.org/r/36934/diff/
>
>
> Testing
> -------
>
> Yes.
>
> 1. Tested with various session conf for lens persistent,driver persistent and inmemory resultset.
> 2. Tested the output through APIs and CLI.
> 3. Tested with compressed result set and split resultset.
> 4. Tested the insertion and retrieval from finished queries table.
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 36934: The file size is obtained using Hadoop
FileSystem APIs
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36934/#review94621
-----------------------------------------------------------
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java (lines 36 - 41)
<https://reviews.apache.org/r/36934/#comment149210>
Should the defaults be null? If some formatter is unable to compute one of them.
incubator-lens/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (line 831)
<https://reviews.apache.org/r/36934/#comment149211>
Would it make sense to sum all file sizes in the directory?
- Rajat Khandelwal
On Aug. 8, 2015, 11:33 a.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36934/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2015, 11:33 a.m.)
>
>
> Review request for lens, Jaideep dhok and Pranav Agarwal.
>
>
> Bugs: LENS-651
> https://issues.apache.org/jira/browse/LENS-651
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added file size in the /resultset api response in case of persistent resultset
>
>
> Diffs
> -----
>
> incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java 70dac08
> incubator-lens/lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 88facda
> incubator-lens/lens-driver-es/src/main/java/org/apache/lens/driver/es/client/ESResultSet.java 4ba2321
> incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 3d1f20a
> incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 82b0568
> incubator-lens/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java f80cdd8
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 48e020f
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java 2c48209
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java aa66b7b
> incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java cc6d918
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java af354cc
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java 13f069f
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 0c78e01
> incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 1d2e89b
> incubator-lens/lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 17dc99b
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 80eb697
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java e392e34
> incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2983db4
> incubator-lens/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java beaa247
>
> Diff: https://reviews.apache.org/r/36934/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 36934: The file size is obtained using Hadoop
FileSystem APIs
Posted by Deepak Barr <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36934/
-----------------------------------------------------------
(Updated Aug. 8, 2015, 6:03 a.m.)
Review request for lens, Jaideep dhok and Pranav Agarwal.
Changes
-------
1. convert types of numRows and fileSize to Integer, Long from int, long.
2. Moved fileSize to PersistentResultSet
3. Included filesize assertion in unit test
4. From lens-cli, numRows appear only when its available.
Bugs: LENS-651
https://issues.apache.org/jira/browse/LENS-651
Repository: lens
Description
-------
Added file size in the /resultset api response in case of persistent resultset
Diffs (updated)
-----
incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java 70dac08
incubator-lens/lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 88facda
incubator-lens/lens-driver-es/src/main/java/org/apache/lens/driver/es/client/ESResultSet.java 4ba2321
incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 3d1f20a
incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 82b0568
incubator-lens/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java f80cdd8
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 48e020f
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java 2c48209
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java aa66b7b
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java cc6d918
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java af354cc
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java 13f069f
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 0c78e01
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 1d2e89b
incubator-lens/lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 17dc99b
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 80eb697
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java e392e34
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2983db4
incubator-lens/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java beaa247
Diff: https://reviews.apache.org/r/36934/diff/
Testing
-------
Yes.
Thanks,
Deepak Barr