You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by mb...@apache.org on 2025/06/06 17:56:28 UTC
(asterixdb) 07/08: [NO ISSUE]: Pass warning collector for COPY TO push runtime factory
This is an automated email from the ASF dual-hosted git repository.
mblow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git
commit 0e2027e43d4f6451bdb75291514dc0c97ac3c09f
Author: Hussain Towaileb <Hu...@Couchbase.com>
AuthorDate: Fri Jun 6 03:54:11 2025 +0300
[NO ISSUE]: Pass warning collector for COPY TO push runtime factory
Ext-ref: MB-66260
Change-Id: I9c38dec618ceb42dae792778df9742ad9dfbc76d
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19874
Reviewed-by: Michael Blow <mb...@apache.org>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Hussain Towaileb <hu...@gmail.com>
---
.../java/org/apache/asterix/metadata/declared/MetadataProvider.java | 2 +-
.../hyracks/algebricks/core/algebra/metadata/IMetadataProvider.java | 3 ++-
.../algebricks/core/algebra/operators/physical/SinkWritePOperator.java | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java
index 63eda21499..71f479f5c3 100644
--- a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java
+++ b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java
@@ -800,7 +800,7 @@ public class MetadataProvider implements IMetadataProvider<DataSourceId, String>
@Override
public Pair<IPushRuntimeFactory, AlgebricksPartitionConstraint> getWriteDatabaseWithKeyRuntime(int sourceColumn,
IScalarEvaluatorFactory[] keyEvaluatorFactories, IWriteDataSink sink, RecordDescriptor inputDesc,
- Object sourceType) throws AlgebricksException {
+ Object sourceType, IWarningCollector warningCollector) throws AlgebricksException {
throw new UnsupportedOperationException();
}
diff --git a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IMetadataProvider.java b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IMetadataProvider.java
index caac0ae5e8..20fc9c54cf 100644
--- a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IMetadataProvider.java
+++ b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IMetadataProvider.java
@@ -41,6 +41,7 @@ import org.apache.hyracks.algebricks.runtime.base.IScalarEvaluatorFactory;
import org.apache.hyracks.api.dataflow.IOperatorDescriptor;
import org.apache.hyracks.api.dataflow.value.IBinaryComparatorFactory;
import org.apache.hyracks.api.dataflow.value.RecordDescriptor;
+import org.apache.hyracks.api.exceptions.IWarningCollector;
import org.apache.hyracks.api.exceptions.SourceLocation;
import org.apache.hyracks.api.job.JobSpecification;
import org.apache.hyracks.api.result.IResultMetadata;
@@ -68,7 +69,7 @@ public interface IMetadataProvider<S, I> {
Pair<IPushRuntimeFactory, AlgebricksPartitionConstraint> getWriteDatabaseWithKeyRuntime(int sourceColumn,
IScalarEvaluatorFactory[] keyEvaluatorFactories, IWriteDataSink sink, RecordDescriptor inputDesc,
- Object sourceType) throws AlgebricksException;
+ Object sourceType, IWarningCollector warningCollector) throws AlgebricksException;
Pair<IOperatorDescriptor, AlgebricksPartitionConstraint> getResultHandleRuntime(IDataSink sink, int[] printColumns,
IPrinterFactory[] printerFactories, IAWriterFactory writerFactory,
diff --git a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/SinkWritePOperator.java b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/SinkWritePOperator.java
index 0428cd1f71..addb6a4539 100644
--- a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/SinkWritePOperator.java
+++ b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/SinkWritePOperator.java
@@ -181,7 +181,7 @@ public class SinkWritePOperator extends AbstractPhysicalOperator {
} else {
runtimeAndConstraints = mp.getWriteDatabaseWithKeyRuntime(sourceColumn, keyEvalFactories, writeDataSink,
- inputDesc, typeEnv.getVarType(sourceVariable));
+ inputDesc, typeEnv.getVarType(sourceVariable), context.getWarningCollector());
}
IPushRuntimeFactory runtime = runtimeAndConstraints.first;